Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unfocus input when virtual keyboard is dismissed #27250

Merged
merged 1 commit into from Jul 13, 2020
Merged

Unfocus input when virtual keyboard is dismissed #27250

merged 1 commit into from Jul 13, 2020

Conversation

paulrouget
Copy link
Contributor

Fix #27181

@highfive
Copy link

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/document.rs, components/constellation/constellation.rs, components/script/script_thread.rs
  • @cbrewster: components/constellation/constellation.rs
  • @KiChjang: components/script/dom/document.rs, components/script/script_thread.rs, components/script_traits/lib.rs

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Jul 13, 2020
@highfive
Copy link

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!

@jdm
Copy link
Member

jdm commented Jul 13, 2020

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit 6252d36 has been approved by jdm

@highfive highfive assigned jdm and unassigned ferjm Jul 13, 2020
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Jul 13, 2020
@bors-servo
Copy link
Contributor

⌛ Testing commit 6252d36 with merge 9bbe9c8...

@bors-servo
Copy link
Contributor

☀️ Test successful - status-taskcluster
Approved by: jdm
Pushing 9bbe9c8 to master...

1 similar comment
@bors-servo
Copy link
Contributor

☀️ Test successful - status-taskcluster
Approved by: jdm
Pushing 9bbe9c8 to master...

@bors-servo bors-servo merged commit 9bbe9c8 into servo:master Jul 13, 2020
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdm jdm jdm approved these changes

Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't reopen on-screen keyboard after closing it when focused on text input
5 participants
@paulrouget @highfive @jdm @bors-servo @ferjm