Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unfocus input when virtual keyboard is dismissed #27250

Merged
merged 1 commit into from Jul 13, 2020
Merged

Unfocus input when virtual keyboard is dismissed #27250

merged 1 commit into from Jul 13, 2020

Conversation

@paulrouget
Copy link
Contributor

paulrouget commented Jul 13, 2020

Fix #27181
@paulrouget
Unfocus input when virtual keyboard is dismissed
Loading status checks…
6252d36
@highfive
Copy link

highfive commented Jul 13, 2020

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/document.rs, components/constellation/constellation.rs, components/script/script_thread.rs
  • @cbrewster: components/constellation/constellation.rs
  • @KiChjang: components/script/dom/document.rs, components/script/script_thread.rs, components/script_traits/lib.rs
@highfive
Copy link

highfive commented Jul 13, 2020

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@jdm
jdm approved these changes Jul 13, 2020
View changes
@jdm
Copy link
Member

jdm commented Jul 13, 2020

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Jul 13, 2020

📌 Commit 6252d36 has been approved by jdm
@highfive highfive assigned jdm and unassigned ferjm Jul 13, 2020
@bors-servo
Copy link
Contributor

bors-servo commented Jul 13, 2020

⌛ Testing commit 6252d36 with merge 9bbe9c8...
@bors-servo
Copy link
Contributor

bors-servo commented Jul 13, 2020

☀️ Test successful - status-taskcluster
Approved by: jdm
Pushing 9bbe9c8 to master...
1 similar comment
@bors-servo
Copy link
Contributor

bors-servo commented Jul 13, 2020

☀️ Test successful - status-taskcluster
Approved by: jdm
Pushing 9bbe9c8 to master...
@bors-servo bors-servo merged commit 9bbe9c8 into servo:master Jul 13, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdm jdm

Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Can't reopen on-screen keyboard after closing it when focused on text input
5 participants
@paulrouget @highfive @jdm @bors-servo @ferjm
You can’t perform that action at this time.