Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Navigator.languages #27264

Merged
merged 1 commit into from Jul 14, 2020
Merged

Implement Navigator.languages #27264

merged 1 commit into from Jul 14, 2020

Conversation

@jdm
Copy link
Member

jdm commented Jul 14, 2020

Fixes #27210.

@highfive
Copy link

highfive commented Jul 14, 2020

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/navigator.rs, components/script/dom/workernavigator.rs, components/script/dom/webidls/Navigator.webidl
  • @KiChjang: components/script/dom/navigator.rs, components/script/dom/workernavigator.rs, components/script/dom/webidls/Navigator.webidl
@jdm
Copy link
Member Author

jdm commented Jul 14, 2020

@highfive highfive assigned Manishearth and unassigned SimonSapin Jul 14, 2020
@Manishearth
Copy link
Member

Manishearth commented Jul 14, 2020

@bors-servo
Copy link
Contributor

bors-servo commented Jul 14, 2020

📌 Commit 2acd295 has been approved by Manishearth

@bors-servo
Copy link
Contributor

bors-servo commented Jul 14, 2020

Testing commit 2acd295 with merge 03bc624...

bors-servo added a commit that referenced this pull request Jul 14, 2020
Implement Navigator.languages

Fixes #27210.
@jdm jdm mentioned this pull request Jul 14, 2020
@bors-servo
Copy link
Contributor

bors-servo commented Jul 14, 2020

💔 Test failed - status-taskcluster

@jdm
Copy link
Member Author

jdm commented Jul 14, 2020

bors-servo added a commit that referenced this pull request Jul 14, 2020
Implement Navigator.languages

Fixes #27210.
@bors-servo
Copy link
Contributor

bors-servo commented Jul 14, 2020

Testing commit 2acd295 with merge 418030a...

@bors-servo
Copy link
Contributor

bors-servo commented Jul 14, 2020

💔 Test failed - status-taskcluster

@Manishearth
Copy link
Member

Manishearth commented Jul 14, 2020

   6: std::sys_common::backtrace::_print
             at /rustc/2753fab7ce3647033146b07c8b6c9f4856a910b0\/src\libstd\sys_common\backtrace.rs:62
   7: std::sys_common::backtrace::print
             at /rustc/2753fab7ce3647033146b07c8b6c9f4856a910b0\/src\libstd\sys_common\backtrace.rs:49
   8: std::panicking::default_hook::{{closure}}
             at /rustc/2753fab7ce3647033146b07c8b6c9f4856a910b0\/src\libstd\panicking.rs:198
   9: std::panicking::default_hook
             at /rustc/2753fab7ce3647033146b07c8b6c9f4856a910b0\/src\libstd\panicking.rs:214
  10: std::panicking::rust_panic_with_hook
             at /rustc/2753fab7ce3647033146b07c8b6c9f4856a910b0\/src\libstd\panicking.rs:526
  11: std::panicking::begin_panic_handler
             at /rustc/2753fab7ce3647033146b07c8b6c9f4856a910b0\/src\libstd\panicking.rs:437
  12: std::panicking::begin_panic_fmt
             at /rustc/2753fab7ce3647033146b07c8b6c9f4856a910b0\/src\libstd\panicking.rs:391
  13: main::http_loader::test_origin_set
             at .\tests\http_loader.rs:1443
  14: main::http_loader::test_origin_set::{{closure}}
             at .\tests\http_loader.rs:1376
  15: core::ops::function::FnOnce::call_once<closure-0,()>
             at /rustc/2753fab7ce3647033146b07c8b6c9f4856a910b0\src\libcore\ops\function.rs:233
  16: alloc::boxed::{{impl}}::call_once
             at /rustc/2753fab7ce3647033146b07c8b6c9f4856a910b0\src\liballoc\boxed.rs:1081
  17: std::panic::{{impl}}::call_once
             at /rustc/2753fab7ce3647033146b07c8b6c9f4856a910b0\src\libstd\panic.rs:318
  18: std::panicking::try::do_call
             at /rustc/2753fab7ce3647033146b07c8b6c9f4856a910b0\src\libstd\panicking.rs:348
  19: std::panicking::try
             at /rustc/2753fab7ce3647033146b07c8b6c9f4856a910b0\src\libstd\panicking.rs:325
  20: std::panic::catch_unwind
             at /rustc/2753fab7ce3647033146b07c8b6c9f4856a910b0\src\libstd\panic.rs:394
  21: test::run_test_in_process
             at /rustc/2753fab7ce3647033146b07c8b6c9f4856a910b0\/src\libtest\lib.rs:541
  22: test::run_test::run_test_inner::{{closure}}
             at /rustc/2753fab7ce3647033146b07c8b6c9f4856a910b0\/src\libtest\lib.rs:450
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
failures:
    http_loader::test_origin_set

@bors-servo retry

@jdm
Copy link
Member Author

jdm commented Jul 14, 2020

That's #26895.

@bors-servo
Copy link
Contributor

bors-servo commented Jul 14, 2020

Testing commit 2acd295 with merge 12d4c0d...

@bors-servo
Copy link
Contributor

bors-servo commented Jul 14, 2020

☀️ Test successful - status-taskcluster
Approved by: Manishearth
Pushing 12d4c0d to master...

@bors-servo bors-servo merged commit 12d4c0d into servo:master Jul 14, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

5 participants
You can’t perform that action at this time.