Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide Window extension methods by default and add helper Window.js_backtrace method #27266

Merged
merged 2 commits into from Jul 15, 2020
Merged

Hide Window extension methods by default and add helper Window.js_backtrace method #27266

merged 2 commits into from Jul 15, 2020

Conversation

@jdm
Copy link
Member

jdm commented Jul 14, 2020

Fixes #26858.
@highfive
Copy link

highfive commented Jul 14, 2020

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/webidls/Window.webidl, components/script/dom/window.rs, components/script/Cargo.toml
  • @KiChjang: components/script/dom/webidls/Window.webidl, components/script/dom/window.rs, components/script/Cargo.toml
@highfive
Copy link

highfive commented Jul 14, 2020

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify script code, but no tests are modified. Please consider adding a test!
@atouchet
atouchet reviewed Jul 14, 2020
View changes
components/script/Cargo.toml Outdated Show resolved Hide resolved
@jdm jdm force-pushed the jdm:hubs-stubs3 branch from 53d33e1 to 58c669b Jul 14, 2020
@Manishearth
Manishearth approved these changes Jul 14, 2020
View changes
Copy link
Member

Manishearth left a comment

Probably should mention the js bt thing in the PR title
@jdm jdm changed the title Hide Window extension methods by default Hide Window extension methods by default and add helper Window.js_backtrace method Jul 14, 2020
@jdm
Copy link
Member Author

jdm commented Jul 14, 2020

@bors-servo r=Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented Jul 14, 2020

📌 Commit 58c669b has been approved by Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented Jul 14, 2020

⌛ Testing commit 58c669b with merge 50ad24e...
bors-servo added a commit that referenced this pull request Jul 14, 2020
@bors-servo
Auto merge of #27266 - jdm:hubs-stubs3, r=Manishearth
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
50ad24e 
Hide Window extension methods by default and add helper Window.js_backtrace method

Fixes #26858.
@bors-servo
Copy link
Contributor

bors-servo commented Jul 14, 2020

💔 Test failed - status-taskcluster
@jdm jdm force-pushed the jdm:hubs-stubs3 branch from 58c669b to f486a70 Jul 14, 2020
@jdm
Copy link
Member Author

jdm commented Jul 14, 2020

@bors-servo r=Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented Jul 14, 2020

📌 Commit f486a70 has been approved by Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented Jul 14, 2020

⌛ Testing commit f486a70 with merge 0388a48...
bors-servo added a commit that referenced this pull request Jul 14, 2020
@bors-servo
Auto merge of #27266 - jdm:hubs-stubs3, r=Manishearth
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
0388a48 
Hide Window extension methods by default and add helper Window.js_backtrace method

Fixes #26858.
@bors-servo
Copy link
Contributor

bors-servo commented Jul 14, 2020

💔 Test failed - status-taskcluster
@jdm jdm force-pushed the jdm:hubs-stubs3 branch from f486a70 to 91436a9 Jul 15, 2020
@jdm
Copy link
Member Author

jdm commented Jul 15, 2020

@bors-servo r=Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented Jul 15, 2020

📌 Commit 91436a9 has been approved by Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented Jul 15, 2020

⌛ Testing commit 91436a9 with merge 9376b73...
bors-servo added a commit that referenced this pull request Jul 15, 2020
@bors-servo
Auto merge of #27266 - jdm:hubs-stubs3, r=Manishearth
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
9376b73 
Hide Window extension methods by default and add helper Window.js_backtrace method

Fixes #26858.
@bors-servo
Copy link
Contributor

bors-servo commented Jul 15, 2020

💔 Test failed - status-taskcluster
jdm added 2 commits Jul 14, 2020
@jdm
dom: Hide debugging extension methods behind a pref.
e6cdfdd
@jdm
dom: Add Window.js_backtrace debugging extension method.
Loading status checks…
4dd7387
@jdm jdm force-pushed the jdm:hubs-stubs3 branch from 91436a9 to 4dd7387 Jul 15, 2020
@jdm
Copy link
Member Author

jdm commented Jul 15, 2020

@bors-servo r=Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented Jul 15, 2020

📌 Commit 4dd7387 has been approved by Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented Jul 15, 2020

⌛ Testing commit 4dd7387 with merge 1e182cd...
@bors-servo
Copy link
Contributor

bors-servo commented Jul 15, 2020

☀️ Test successful - status-taskcluster
Approved by: Manishearth
Pushing 1e182cd to master...
@bors-servo bors-servo merged commit 1e182cd into servo:master Jul 15, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atouchet atouchet

@Manishearth Manishearth

Assignees

@Manishearth Manishearth

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Add API for dumping current JS/Rust backtraces
5 participants
@jdm @highfive @bors-servo @Manishearth @atouchet
You can’t perform that action at this time.