Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use `Rc` instead of cloning the `DOMString` #27282

Merged
merged 3 commits into from Jul 17, 2020
Merged

Use `Rc` instead of cloning the `DOMString` #27282

merged 3 commits into from Jul 17, 2020
+23 −19

Commits on Jul 15, 2020

  1. Use `Rc` instead of cloning the `DOMString` 

    Specifically, I changed the `text` field of `ScriptOrigin` from a
`DOMString` to an `Rc<DOMString>`. Then I updated all the related code
to work with an `Rc`.

This is just a first pass to get the code to compile. There are probably
more things I can do that will improve the code and further reduce
cloning.
    @camelid
    camelid committed Jul 15, 2020
    Loading status checks…
    69881e8

Commits on Jul 17, 2020

  1. Fewer clones

    @camelid
    camelid committed Jul 17, 2020
    3f440bd

  2. One fewer `Rc::clone()`

    @camelid
    camelid committed Jul 17, 2020
    Loading status checks…
    cdfd4d9
You can’t perform that action at this time.