Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gstreamer plugin support for streaming from webxr #27295

Merged
merged 2 commits into from Jul 17, 2020

Conversation

asajeffrey
Copy link
Member

@asajeffrey asajeffrey commented Jul 16, 2020

Allows us to stream webxr video content.


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes do not require tests because we don't reftest the gstreamer plugin

@highfive
Copy link

highfive commented Jul 16, 2020

Heads up! This PR modifies the following files:

  • @KiChjang: components/script/dom/document.rs

@highfive
Copy link

highfive commented Jul 16, 2020

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!

@asajeffrey asajeffrey marked this pull request as ready for review Jul 16, 2020
@asajeffrey
Copy link
Member Author

asajeffrey commented Jul 16, 2020

r? @Manishearth

@highfive highfive assigned Manishearth and unassigned jdm Jul 16, 2020
@asajeffrey
Copy link
Member Author

asajeffrey commented Jul 17, 2020

@bors-servo r=Manishearth

1 similar comment
@jdm
Copy link
Member

jdm commented Jul 17, 2020

@bors-servo r=Manishearth

@bors-servo
Copy link
Contributor

bors-servo commented Jul 17, 2020

📌 Commit ec9f1fe has been approved by Manishearth

@bors-servo
Copy link
Contributor

bors-servo commented Jul 17, 2020

Testing commit ec9f1fe with merge 8ce3ff6...

@bors-servo
Copy link
Contributor

bors-servo commented Jul 17, 2020

☀️ Test successful - status-taskcluster
Approved by: Manishearth
Pushing 8ce3ff6 to master...

@bors-servo bors-servo merged commit 8ce3ff6 into servo:master Jul 17, 2020
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants