Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove explicit Host header from websocket connection. #27300

Merged
merged 1 commit into from Jul 16, 2020

Conversation

jdm
Copy link
Member

@jdm jdm commented Jul 16, 2020

This was a regression from #27164, and fixing it allows hubs.mozilla.com to work again.

@jdm jdm changed the title net: Remove explicit Host header from websocket connection. Remove explicit Host header from websocket connection. Jul 16, 2020
@highfive
Copy link

highfive commented Jul 16, 2020

Heads up! This PR modifies the following files:

  • @KiChjang: components/net/websocket_loader.rs

@highfive
Copy link

highfive commented Jul 16, 2020

warning Warning warning

  • These commits modify net code, but no tests are modified. Please consider adding a test!

@asajeffrey
Copy link
Member

asajeffrey commented Jul 16, 2020

@bors-servo r+

@bors-servo
Copy link
Contributor

bors-servo commented Jul 16, 2020

📌 Commit d5d8edd has been approved by asajeffrey

bors-servo added a commit that referenced this issue Jul 16, 2020
Remove explicit Host header from websocket connection.

This was a regression from #27164, and fixing it allows hubs.mozilla.com to work again.
@bors-servo
Copy link
Contributor

bors-servo commented Jul 16, 2020

Testing commit d5d8edd with merge 7439f86...

@bors-servo
Copy link
Contributor

bors-servo commented Jul 16, 2020

💔 Test failed - status-taskcluster

@jdm
Copy link
Member Author

jdm commented Jul 16, 2020

@bors-servo
Copy link
Contributor

bors-servo commented Jul 16, 2020

Testing commit d5d8edd with merge b17a302...

@bors-servo
Copy link
Contributor

bors-servo commented Jul 16, 2020

☀️ Test successful - status-taskcluster
Approved by: asajeffrey
Pushing b17a302 to master...

@bors-servo bors-servo merged commit b17a302 into servo:master Jul 16, 2020
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants