Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upMake gstreamer packaging explicit #27302
Merged
Conversation
highfive
commented
Jul 16, 2020
|
Heads up! This PR modifies the following files:
|
|
r? @Manishearth |
|
I verified that a local build could still use webaudio, getUserMedia, and media elements after these changes. |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Jul 16, 2020
Make gstreamer packaging explicit This change aligns Windows and macOS in terms of loading an explicit set of included plugins when initializing gstreamer. It also creates a single source of truth - the set of expected plugins is generated in a build script by the same python code that is used for packaging, so it should be impossible for platforms relying on this system to get out of sync. Fixes #27293
|
|
|
@bors-servo try=wpt-mac |
bors-servo
added a commit
that referenced
this pull request
Jul 16, 2020
Make gstreamer packaging explicit This change aligns Windows and macOS in terms of loading an explicit set of included plugins when initializing gstreamer. It also creates a single source of truth - the set of expected plugins is generated in a build script by the same python code that is used for packaging, so it should be impossible for platforms relying on this system to get out of sync. Fixes #27293
|
|
|
@bors-servo r=Manishearth |
|
|
bors-servo
added a commit
that referenced
this pull request
Jul 17, 2020
Make gstreamer packaging explicit This change aligns Windows and macOS in terms of loading an explicit set of included plugins when initializing gstreamer. It also creates a single source of truth - the set of expected plugins is generated in a build script by the same python code that is used for packaging, so it should be impossible for platforms relying on this system to get out of sync. Fixes #27293
…the nightly package.
|
@bors-servo r=Manishearth |
|
|
bors-servo
added a commit
that referenced
this pull request
Jul 17, 2020
Make gstreamer packaging explicit This change aligns Windows and macOS in terms of loading an explicit set of included plugins when initializing gstreamer. It also creates a single source of truth - the set of expected plugins is generated in a build script by the same python code that is used for packaging, so it should be impossible for platforms relying on this system to get out of sync. Fixes #27293
|
|
|
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Jul 17, 2020
Make gstreamer packaging explicit This change aligns Windows and macOS in terms of loading an explicit set of included plugins when initializing gstreamer. It also creates a single source of truth - the set of expected plugins is generated in a build script by the same python code that is used for packaging, so it should be impossible for platforms relying on this system to get out of sync. Fixes #27293
|
|
|
@bors-servo retry |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
jdm commentedJul 16, 2020
•
edited
This change aligns Windows and macOS in terms of loading an explicit set of included plugins when initializing gstreamer. It also creates a single source of truth - the set of expected plugins is generated in a build script by the same python code that is used for packaging, so it should be impossible for platforms relying on this system to get out of sync.
Fixes #27293