Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUWP: non random port for devtools, and support for custom UWP prefs #27304
Conversation
|
This is a nice cleanup! |
d739c0a
to
546c894
Good catch. Fixed. |
|
Hold on. I found a regression. |
546c894
to
b56dccb
|
The way the homepage pref was overridden wouldn't work because we were relying on the fact that the UWP pref always had a shell.homepage key, which is not the case anymore as we use the servo pref. Fixed with: 9174b20#diff-831a752eac48b390b35aae339dbc1097R375 |
Merged
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Jul 20, 2020
UWP: non random port for devtools, and support for custom UWP prefs packages-prefs.json is now taken into account for libsimpleservo. Making it possible to have custom pref for the UWP builds, removing some weirdness in the way we handle preferences in the hololens code. This also adds a new set of preferences to control the devtools server startup state, and make the port choice constant across sessions. Fix #27267 Fix #22970
|
|
|
b56dccb
to
1b0de56
|
@bors-servo r=jdm |
|
|
|
|
bors-servo
added a commit
that referenced
this pull request
Jul 23, 2020
bors-servo
added a commit
that referenced
this pull request
Jul 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
paulrouget commentedJul 17, 2020
•
edited
packages-prefs.json is now taken into account for libsimpleservo. Making it possible to have custom pref for the UWP builds, removing some weirdness in the way we handle preferences in the hololens code.
This also adds a new set of preferences to control the devtools server startup state, and make the port choice constant across sessions.
Fix #27267
Fix #22970