Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update XRWebGLLayer to match specification. #27313

Merged
merged 1 commit into from Jul 21, 2020
Merged

Update XRWebGLLayer to match specification. #27313

merged 1 commit into from Jul 21, 2020
+37 −309

Conversation

@jdm
Copy link
Member

jdm commented Jul 17, 2020

This unbreaks most of the webxr WPT tests.

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #27312
  • There are tests for these changes
@highfive
Copy link

highfive commented Jul 17, 2020

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/xrwebgllayer.rs, components/script/dom/xrsession.rs, components/script/dom/webidls/XRWebGLLayer.webidl
  • @KiChjang: components/script/dom/xrwebgllayer.rs, components/script/dom/xrsession.rs, components/script/dom/webidls/XRWebGLLayer.webidl
@jdm
Copy link
Member Author

jdm commented Jul 17, 2020

@bors-servo try=wpt
@bors-servo
Copy link
Contributor

bors-servo commented Jul 17, 2020

⌛ Trying commit b606e54 with merge e13d5b8...
bors-servo added a commit that referenced this pull request Jul 17, 2020
@bors-servo
Auto merge of #27313 - jdm:layer-idl, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
e13d5b8 
Update XRWebGLLayer to match specification.

This unbreaks most of the webxr WPT tests.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #27312
- [x] There are tests for these changes
@asajeffrey
asajeffrey approved these changes Jul 17, 2020
View changes
Copy link
Member

asajeffrey left a comment

OK, you win the award for the ratio of size of change to number of newly-passing tests.
@bors-servo
Copy link
Contributor

bors-servo commented Jul 17, 2020

💔 Test failed - status-taskcluster
@jdm
Copy link
Member Author

jdm commented Jul 17, 2020 

  ▶ ERROR [expected TIMEOUT] /webxr/dom-overlay/ar_dom_overlay.https.html
  │   → input_source.setOverlayPointerPosition is not a function
  │ 
  └ testInput/</<@https://web-platform.test:8443/webxr/dom-overlay/ar_dom_overlay.https.html:142:20
  ▶ Unexpected subtest result in /webxr/dom-overlay/ar_dom_overlay.https.html:
  │ TIMEOUT [expected FAIL] Ensures DOM Overlay input deduplication works
  └   → Test timed out
  ▶ Unexpected subtest result in /webxr/dom-overlay/ar_dom_overlay.https.html:
  └ NOTRUN [expected FAIL] Ensures DOM Overlay Fullscreen API doesn't change DOM overlay
  ▶ Unexpected subtest result in /webxr/dom-overlay/ar_dom_overlay.https.html:
  └ NOTRUN [expected FAIL] Ensures DOM Overlay interactions on cross origin iframe are ignored

  ▶ ERROR [expected TIMEOUT] /webxr/hit-test/ar_hittest_subscription_transientInputSources.https.html
  │   → session.requestHitTestSourceForTransientInput is not a function
  │ 
  └ testFunction/</</<@https://web-platform.test:8443/webxr/hit-test/ar_hittest_subscription_transientInputSources.https.html:70:17
  ▶ Unexpected subtest result in /webxr/hit-test/ar_hittest_subscription_transientInputSources.https.html:
  │ TIMEOUT [expected FAIL] Ensures subscription to transient hit test works with an XRSpace from input source - no move
  └   → Test timed out
  ▶ Unexpected subtest result in /webxr/hit-test/ar_hittest_subscription_transientInputSources.https.html:
  └ NOTRUN [expected FAIL] Ensures subscription to transient hit test works with an XRSpace from input source - after move - no results
  ▶ Unexpected subtest result in /webxr/hit-test/ar_hittest_subscription_transientInputSources.https.html:
  └ NOTRUN [expected FAIL] Ensures subscription to transient hit test works with an XRSpace from input source - after move - 1 result

  ▶ Unexpected subtest result in /webxr/xrSession_cancelAnimationFrame_invalidhandle.https.html:
  │ TIMEOUT [expected FAIL] XRSession cancelAnimationFrame does not have unexpected behavior when given invalid handles on immersive testSession
  └   → Test timed out
  ▶ Unexpected subtest result in /webxr/xrSession_cancelAnimationFrame_invalidhandle.https.html:
  └ NOTRUN [expected FAIL] XRSession cancelAnimationFrame does not have unexpected behavior when given invalid handles on non-immersive testSession
  ▶ Unexpected subtest result in /webxr/xrDevice_disconnect_ends.https.html:
  │ TIMEOUT [expected FAIL] Immersive session ends when device is disconnected
  └   → Test timed out
@jdm jdm force-pushed the jdm:layer-idl branch from b606e54 to f425e75 Jul 20, 2020
@jdm
Update XRWebGLLayer to match specification.
Loading status checks…
c34e587
@jdm jdm force-pushed the jdm:layer-idl branch from f425e75 to c34e587 Jul 20, 2020
@jdm
Copy link
Member Author

jdm commented Jul 20, 2020

@bors-servo try=wpt
@bors-servo
Copy link
Contributor

bors-servo commented Jul 20, 2020

⌛ Trying commit c34e587 with merge 6ef3747...
bors-servo added a commit that referenced this pull request Jul 20, 2020
@bors-servo
Auto merge of #27313 - jdm:layer-idl, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
6ef3747 
Update XRWebGLLayer to match specification.

This unbreaks most of the webxr WPT tests.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #27312
- [x] There are tests for these changes
@bors-servo
Copy link
Contributor

bors-servo commented Jul 20, 2020

☀️ Test successful - status-taskcluster
State: approved= try=True
@jdm
Copy link
Member Author

jdm commented Jul 20, 2020

@bors-servo r=asajeffrey
@bors-servo
Copy link
Contributor

bors-servo commented Jul 20, 2020

📌 Commit c34e587 has been approved by asajeffrey
@highfive highfive assigned asajeffrey and unassigned ferjm Jul 20, 2020
@bors-servo
Copy link
Contributor

bors-servo commented Jul 20, 2020

⌛ Testing commit c34e587 with merge 8443e98...
bors-servo added a commit that referenced this pull request Jul 20, 2020
@bors-servo
Auto merge of #27313 - jdm:layer-idl, r=asajeffrey
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
8443e98 
Update XRWebGLLayer to match specification.

This unbreaks most of the webxr WPT tests.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #27312
- [x] There are tests for these changes
@bors-servo
Copy link
Contributor

bors-servo commented Jul 21, 2020

💔 Test failed - status-taskcluster
@jdm
Copy link
Member Author

jdm commented Jul 21, 2020

@bors-servo retry
bors-servo added a commit that referenced this pull request Jul 21, 2020
@bors-servo
Auto merge of #27313 - jdm:layer-idl, r=asajeffrey
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
53bbee8 
Update XRWebGLLayer to match specification.

This unbreaks most of the webxr WPT tests.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #27312
- [x] There are tests for these changes
@bors-servo
Copy link
Contributor

bors-servo commented Jul 21, 2020

⌛ Testing commit c34e587 with merge 53bbee8...
@bors-servo
Copy link
Contributor

bors-servo commented Jul 21, 2020

💔 Test failed - status-taskcluster
@jdm
Copy link
Member Author

jdm commented Jul 21, 2020

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Jul 21, 2020

⌛ Testing commit c34e587 with merge c0778ff...
@bors-servo
Copy link
Contributor

bors-servo commented Jul 21, 2020

☀️ Test successful - status-taskcluster
Approved by: asajeffrey
Pushing c0778ff to master...
@bors-servo bors-servo merged commit c0778ff into servo:master Jul 21, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asajeffrey asajeffrey

Assignees

@asajeffrey asajeffrey

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

XRWebGLLayer IDL members don't match the specification
5 participants
@jdm @highfive @bors-servo @asajeffrey @ferjm
You can’t perform that action at this time.