Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GPUObjectBase webidl and cleanup valid flags #27329

Merged
merged 1 commit into from Jul 21, 2020

Conversation

kunalmohan
Copy link
Collaborator

@kunalmohan kunalmohan commented Jul 20, 2020

Update labels to be USVString
Remove valid flags in WebGPU resources. The only place where we still have that is GPUCommandEncoder (Only to validate the GPUCommandEncoder state. Not sure how errors would be handled/reported by server for copy commands).

r?@kvark


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #___ (GitHub issue number if applicable)
  • There are tests for these changes OR
  • These changes do not require tests because ___

@highfive
Copy link

highfive commented Jul 20, 2020

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/gpubindgrouplayout.rs, components/script/dom/gpucommandbuffer.rs, components/script/dom/gpushadermodule.rs, components/script/dom/gpucomputepassencoder.rs, components/script/dom/gpuqueue.rs and 13 more
  • @KiChjang: components/script/dom/gpubindgrouplayout.rs, components/script/dom/gpucommandbuffer.rs, components/script/dom/gpushadermodule.rs, components/script/dom/gpucomputepassencoder.rs, components/script/dom/gpuqueue.rs and 13 more

@highfive
Copy link

highfive commented Jul 20, 2020

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!

@kunalmohan kunalmohan added this to In progress in WebGPU MVP via automation Jul 20, 2020
kvark
kvark approved these changes Jul 20, 2020
@jdm
Copy link
Member

jdm commented Jul 20, 2020

@bors-servo r=kvark

@bors-servo
Copy link
Contributor

bors-servo commented Jul 20, 2020

📌 Commit cdc0a75 has been approved by kvark

@bors-servo
Copy link
Contributor

bors-servo commented Jul 20, 2020

Testing commit cdc0a75 with merge 8c4b25b...

bors-servo added a commit that referenced this issue Jul 20, 2020
Update GPUObjectBase webidl and cleanup valid flags

<!-- Please describe your changes on the following line: -->
Update labels to be `USVString`
Remove `valid` flags in WebGPU resources. The only place where we still have that is `GPUCommandEncoder` (Only to validate the GPUCommandEncoder state. Not sure how errors would be handled/reported by server for copy commands).

r?@kvark

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #___ (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

bors-servo commented Jul 20, 2020

💔 Test failed - status-taskcluster

bors-servo added a commit that referenced this issue Jul 20, 2020
Update GPUObjectBase webidl and cleanup valid flags

<!-- Please describe your changes on the following line: -->
Update labels to be `USVString`
Remove `valid` flags in WebGPU resources. The only place where we still have that is `GPUCommandEncoder` (Only to validate the GPUCommandEncoder state. Not sure how errors would be handled/reported by server for copy commands).

r?@kvark

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #___ (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

bors-servo commented Jul 20, 2020

Testing commit cdc0a75 with merge 332cb88...

@bors-servo
Copy link
Contributor

bors-servo commented Jul 20, 2020

💔 Test failed - status-taskcluster

@jdm
Copy link
Member

jdm commented Jul 20, 2020

@bors-servo retry

@bors-servo
Copy link
Contributor

bors-servo commented Jul 21, 2020

Testing commit cdc0a75 with merge 5984137...

@bors-servo
Copy link
Contributor

bors-servo commented Jul 21, 2020

☀️ Test successful - status-taskcluster
Approved by: kvark
Pushing 5984137 to master...

@bors-servo bors-servo merged commit 5984137 into servo:master Jul 21, 2020
2 checks passed
WebGPU MVP automation moved this from In progress to Done Jul 21, 2020
@kunalmohan kunalmohan deleted the gpu-label branch Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
WebGPU MVP
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants