Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upHandle flex item cross sizing and minmax for flexbox in 2020 #27334
+12
−99
Conversation
Manishearth
changed the title
|
Looks good to me. |
|
@bors-servo r=pcwalton I updated expectations for the wrong folder |
|
|
bors-servo
added a commit
that referenced
this pull request
Jul 20, 2020
Handle flex item cross sizing and minmax for flexbox in 2020 Note: a lot more tests pass, however update-wpt is somehow not accepting them. I'm going to try and do an update again.
|
Actually this is buggy but it doesn't matter since it's buggy around its align-items behavior which is hardcoded anyway |
|
Oh, no, it's not. |
|
|
|
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Jul 21, 2020
flexbox 2020: Implement `align-items` and `align-self`, excluding `baseline` This PR is based on #27334 for ease of testing `baseline` is tricky and involves keeping track of a "baseline set" https://drafts.csswg.org/css-flexbox/#flex-baselines Part of #26639
bors-servo
added a commit
that referenced
this pull request
Jul 21, 2020
flexbox 2020: Implement `align-items` and `align-self`, excluding `baseline` This PR is based on #27334 for ease of testing `baseline` is tricky and involves keeping track of a "baseline set" https://drafts.csswg.org/css-flexbox/#flex-baselines Part of #26639
bors-servo
added a commit
that referenced
this pull request
Jul 21, 2020
flexbox 2020: Implement `align-items` and `align-self`, excluding `baseline` This PR is based on #27334 for ease of testing `baseline` is tricky and involves keeping track of a "baseline set" https://drafts.csswg.org/css-flexbox/#flex-baselines Part of #26639
bors-servo
added a commit
that referenced
this pull request
Jul 21, 2020
flexbox 2020: Implement `align-items` and `align-self`, excluding `baseline` This PR is based on #27334 for ease of testing `baseline` is tricky and involves keeping track of a "baseline set" https://drafts.csswg.org/css-flexbox/#flex-baselines Part of #26639
|
CC #27334 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Manishearth commentedJul 20, 2020
Note: a lot more tests pass, however update-wpt is somehow not accepting them. I'm going to try and do an update again.