Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle apostrophes for whatwg URL tidy check #27377

Merged
merged 1 commit into from Jul 24, 2020
Merged

Conversation

@CYBAI
Copy link
Collaborator

CYBAI commented Jul 23, 2020


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #27366
  • These changes do not require tests because it will improve the tidy check for WHATWG URL
@highfive
Copy link

highfive commented Jul 23, 2020

Heads up! This PR modifies the following files:

@CYBAI
Copy link
Collaborator Author

CYBAI commented Jul 23, 2020

hmm, I will see a flake8 error locally. Let me see if it will throw the error in TC :/

Checking files for tidiness...
  Progress: 100% (1/1)Traceback (most recent call last):
  File "/Volumes/Transcend/codespace/mozilla/servo/python/_virtualenv2.7/bin/flake8", line 8, in <module>
    sys.exit(main())
  File "/Volumes/Transcend/codespace/mozilla/servo/python/_virtualenv2.7/lib/python2.7/site-packages/flake8/main/cli.py", line 22, in main
    app.run(argv)
  File "/Volumes/Transcend/codespace/mozilla/servo/python/_virtualenv2.7/lib/python2.7/site-packages/flake8/main/application.py", line 360, in run
    self._run(argv)
  File "/Volumes/Transcend/codespace/mozilla/servo/python/_virtualenv2.7/lib/python2.7/site-packages/flake8/main/application.py", line 347, in _run
    self.initialize(argv)
  File "/Volumes/Transcend/codespace/mozilla/servo/python/_virtualenv2.7/lib/python2.7/site-packages/flake8/main/application.py", line 328, in initialize
    self.find_plugins(config_finder)
  File "/Volumes/Transcend/codespace/mozilla/servo/python/_virtualenv2.7/lib/python2.7/site-packages/flake8/main/application.py", line 159, in find_plugins
    self.check_plugins.load_plugins()
  File "/Volumes/Transcend/codespace/mozilla/servo/python/_virtualenv2.7/lib/python2.7/site-packages/flake8/plugins/manager.py", line 415, in load_plugins
    plugins = list(self.manager.map(load_plugin))
  File "/Volumes/Transcend/codespace/mozilla/servo/python/_virtualenv2.7/lib/python2.7/site-packages/flake8/plugins/manager.py", line 302, in map
    yield func(self.plugins[name], *args, **kwargs)
  File "/Volumes/Transcend/codespace/mozilla/servo/python/_virtualenv2.7/lib/python2.7/site-packages/flake8/plugins/manager.py", line 413, in load_plugin
    return plugin.load_plugin()
  File "/Volumes/Transcend/codespace/mozilla/servo/python/_virtualenv2.7/lib/python2.7/site-packages/flake8/plugins/manager.py", line 164, in load_plugin
    raise failed_to_load
flake8.exceptions.FailedToLoadPlugin: Flake8 failed to load plugin "pycodestyle.break_around_binary_operator" due to 'module' object has no attribute 'break_around_binary_operator'.

tidy reported no errors.
@jdm
Copy link
Member

jdm commented Jul 24, 2020

@bors-servo r+
Thanks!

@bors-servo
Copy link
Contributor

bors-servo commented Jul 24, 2020

📌 Commit 584e031 has been approved by jdm

@highfive highfive assigned jdm and unassigned SimonSapin Jul 24, 2020
@CYBAI
Copy link
Collaborator Author

CYBAI commented Jul 24, 2020

There's no such error like #27377 (comment) in TC; I will see how to fix it for my local environment.

+ ./mach test-tidy --no-progress --all
 0:06.99�(B INFO�(B Diffing old and new manifests /repo/tests/wpt/mozilla/meta/MANIFEST.json
 0:07.55�(B INFO�(B Diffing old and new manifests /repo/tests/wpt/webgl/meta/MANIFEST.json
 0:08.26�(B INFO�(B Diffing old and new manifests /repo/tests/wpt/metadata/MANIFEST.json
Checking the config file...
Checking the wpt manifest file...
Checking directories for correct file extensions...
Running the WPT lint on ./tests/wpt/web-platform-tests/...
Running the WPT lint on ./tests/wpt/mozilla/tests/...
Checking files for tidiness...
Running the dependency licensing lint...
@bors-servo
Copy link
Contributor

bors-servo commented Jul 24, 2020

Testing commit 584e031 with merge 70c59d2...

bors-servo added a commit that referenced this pull request Jul 24, 2020
Handle apostrophes for whatwg URL tidy check

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #27366
- [x] These changes do not require tests because it will improve the tidy check for WHATWG URL

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

bors-servo commented Jul 24, 2020

💔 Test failed - status-taskcluster

@jdm
Copy link
Member

jdm commented Jul 24, 2020

@bors-servo
Copy link
Contributor

bors-servo commented Jul 24, 2020

Testing commit 584e031 with merge 7eda4d2...

@bors-servo
Copy link
Contributor

bors-servo commented Jul 24, 2020

☀️ Test successful - status-taskcluster
Approved by: jdm
Pushing 7eda4d2 to master...

@bors-servo bors-servo merged commit 7eda4d2 into servo:master Jul 24, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
@CYBAI CYBAI deleted the CYBAI:fix-apostrophes branch Jul 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

5 participants
You can’t perform that action at this time.