Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd Layout 2020 support for `display: list-item` #27385
Merged
+225
−92
Conversation
highfive
commented
Jul 23, 2020
|
Heads up! This PR modifies the following files:
|
| UrlOrNone::None => None, | ||
| }; | ||
| marker_image().or_else(|| { | ||
| Some(vec
This comment has been minimized.
This comment has been minimized.
SimonSapin
Jul 23, 2020
Author
Member
The closure uses ? so it has two paths that can return None. This implements “If the <image> represents a valid image” in https://drafts.csswg.org/css-lists/#marker-image
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Jul 24, 2020
Add Layout 2020 support for `display: list-item`
|
|
|
@bors-servo retry |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
SimonSapin commentedJul 23, 2020
No description provided.