Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upLayout 2020: Implement `clip: rect` #27388
Merged
+5,146
−153
Conversation
highfive
commented
Jul 24, 2020
|
r? @SimonSapin or @pcwalton |
Manishearth
changed the title
|
The last commit fixes the problem, but I'm not sure if it's the right fix. |
|
As discussed on Matrix https://drafts.csswg.org/css2/#clipping says
So this PR should also change |
| From::from(self.left.auto_is(|| Length::new(0.))), | ||
| From::from(self.top.auto_is(|| Length::new(0.))), |
Comment on lines
+834
to
+835
This comment has been minimized.
This comment has been minimized.
| let clip = self.style.get_effects().clip; | ||
| if let ClipRectOrAuto::Rect(r) = clip { |
Comment on lines
718
to
719
This comment has been minimized.
This comment has been minimized.
SimonSapin
Jul 27, 2020
Member
https://drafts.csswg.org/css2/#clipping
The clip property applies only to absolutely positioned elements.
So this code should also check for position: absolute or position: fixed.
|
Let’s try this on top of #27399 @bors-servo try=wpt-2020 |
bors-servo
added a commit
that referenced
this pull request
Jul 27, 2020
Layout 2020: Implement `clip: rect` This implements `clip: rect` Unfortunately, none of the tests pass yet, they are all broken due to #27387 Additionally, currently `clip` does not seem to clip the element itself, only its children. I'm not quite sure what to do about that, I patterned this off of the code in the layout 2013 which handled clip immediately after scroll overflow.
|
|
|
Sweet, a whole pile of PASS expected FAIL. Though i bet many of these would have been PASS expected FAIL before this PR, I plan to rebase and do a two-step test update. |
|
PR updated with tests |
|
So the clip-not-absolute-positioned tests are failing, because my impl seems to apply universally rather than to positioned elements |
|
Fixed |
|
More |
|
@bors-servo r=SimonSapin |
|
|
bors-servo
added a commit
that referenced
this pull request
Jul 28, 2020
Layout 2020: Implement `clip: rect` This implements `clip: rect` Unfortunately, none of the tests pass yet, they are all broken due to #27387 Additionally, currently `clip` does not seem to clip the element itself, only its children. I'm not quite sure what to do about that, I patterned this off of the code in the layout 2013 which handled clip immediately after scroll overflow.
|
|
|
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Jul 28, 2020
Layout 2020: Implement `clip: rect` This implements `clip: rect` Unfortunately, none of the tests pass yet, they are all broken due to #27387 Additionally, currently `clip` does not seem to clip the element itself, only its children. I'm not quite sure what to do about that, I patterned this off of the code in the layout 2013 which handled clip immediately after scroll overflow.
|
|
|
@bors-servo retry |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Manishearth commentedJul 24, 2020
This implements
clip: rectUnfortunately, none of the tests pass yet, they are all broken due to #27387
Additionally, currently
clipdoes not seem to clip the element itself, only its children. I'm not quite sure what to do about that, I patterned this off of the code in the layout 2013 which handled clip immediately after scroll overflow.