Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement GPURenderBundles #27389

Merged
merged 2 commits into from Jul 24, 2020
Merged

Implement GPURenderBundles #27389

merged 2 commits into from Jul 24, 2020

Conversation

kunalmohan
Copy link
Collaborator

@kunalmohan kunalmohan commented Jul 24, 2020

  1. Implement GPURenderBundleEncoder and GPURenderBundle.
  2. Update wgpu to use serializable descriptors.
  3. Set user-defined labels on object creation.

r?@kvark


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors

@highfive
Copy link

highfive commented Jul 24, 2020

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/gpubindgrouplayout.rs, components/script/dom/gpucommandbuffer.rs, components/script/dom/gpurenderbundleencoder.rs, components/script/dom/mod.rs, components/script/dom/gpubuffer.rs and 24 more
  • @KiChjang: components/script/dom/gpubindgrouplayout.rs, components/script/dom/gpucommandbuffer.rs, components/script/dom/gpurenderbundleencoder.rs, components/script/dom/mod.rs, components/script/dom/gpubuffer.rs and 24 more

@highfive
Copy link

highfive commented Jul 24, 2020

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify script code, but no tests are modified. Please consider adding a test!

@kunalmohan kunalmohan added this to In progress in WebGPU MVP via automation Jul 24, 2020
kvark
kvark approved these changes Jul 24, 2020
Copy link
Member

@kvark kvark left a comment

very nice!

@kvark
Copy link
Member

kvark commented Jul 24, 2020

@bors-servo r+

@bors-servo
Copy link
Contributor

bors-servo commented Jul 24, 2020

📌 Commit aff22db has been approved by kvark

@bors-servo
Copy link
Contributor

bors-servo commented Jul 24, 2020

Testing commit aff22db with merge ebec798...

@bors-servo
Copy link
Contributor

bors-servo commented Jul 24, 2020

☀️ Test successful - status-taskcluster
Approved by: kvark
Pushing ebec798 to master...

@bors-servo bors-servo merged commit ebec798 into servo:master Jul 24, 2020
2 checks passed
WebGPU MVP automation moved this from In progress to Done Jul 24, 2020
@kunalmohan kunalmohan deleted the update-wgpu branch Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
WebGPU MVP
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants