Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unit test that triggers frequent intermittent failure. #27393

Merged
merged 1 commit into from Jul 27, 2020

Conversation

@jdm
Copy link
Member

jdm commented Jul 24, 2020

This works around #26895 by removing the test that triggers it. The underlying cause of the failure isn't clear, but it's something to do with the hyper server and doesn't appear to impact the way that Servo's HTTP stack functions. The unit test itself is testing one particular property of the way CORS requests are made with HEAD requests, and that's not a property that is critical functionality if we stop testing it.

@highfive
Copy link

highfive commented Jul 24, 2020

Heads up! This PR modifies the following files:

  • @KiChjang: components/net/tests/http_loader.rs
@jdm
Copy link
Member Author

jdm commented Jul 24, 2020

@highfive highfive assigned asajeffrey and unassigned ferjm Jul 24, 2020
@SimonSapin
Copy link
Member

SimonSapin commented Jul 24, 2020

error: unused imports: `AccessControlAllowOrigin`, `Origin`
  --> components/net/tests/http_loader.rs:19:5
   |
19 |     AccessControlAllowOrigin, Authorization, ContentLength, Date, HeaderMapExt, Host, Origin,
   |     ^^^^^^^^^^^^^^^^^^^^^^^^                                                          ^^^^^^
   |
   = note: `-D unused-imports` implied by `-D warnings`
error: unused import: `RequestMode`
  --> components/net/tests/http_loader.rs:37:34
   |
37 |     RequestBody, RequestBuilder, RequestMode,
   |                                  ^^^^^^^^^^^
@jdm jdm force-pushed the jdm-patch-47 branch from fdbca66 to 79e8a05 Jul 24, 2020
@CYBAI
Copy link
Collaborator

CYBAI commented Jul 26, 2020

Missing one 👀

error: unused import: `Origin`
  --> components/net/tests/http_loader.rs:19:61
   |
19 |     Authorization, ContentLength, Date, HeaderMapExt, Host, Origin, StrictTransportSecurity,
   |                                                             ^^^^^^
   |
   = note: `-D unused-imports` implied by `-D warnings`
@jdm jdm force-pushed the jdm-patch-47 branch from 79e8a05 to 7775833 Jul 27, 2020
@nox
Copy link
Member

nox commented Jul 27, 2020

@bors-servo
Copy link
Contributor

bors-servo commented Jul 27, 2020

📌 Commit 7775833 has been approved by nox

@highfive highfive assigned nox and unassigned asajeffrey Jul 27, 2020
@bors-servo
Copy link
Contributor

bors-servo commented Jul 27, 2020

Testing commit 7775833 with merge 5a8023d...

@bors-servo
Copy link
Contributor

bors-servo commented Jul 27, 2020

☀️ Test successful - status-taskcluster
Approved by: nox
Pushing 5a8023d to master...

@bors-servo bors-servo merged commit 5a8023d into master Jul 27, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
@bors-servo bors-servo deleted the jdm-patch-47 branch Jul 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

8 participants
You can’t perform that action at this time.