Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign up[return value version] Handle `inset: auto` values for absolutely positioned elements #27397
+111
−42
Conversation
|
@bors-servo try running the entire css suite is taking forever, and also apparently my computer is fast enough to turn some of the timeouts into other errors |
bors-servo
added a commit
that referenced
this pull request
Jul 24, 2020
Handle `inset: auto` values for absolutely positioned elements Fixes #27387 I'm not 100% sure of this approach, i don't like reconstructing the vector there. Also, when tried on the testcase in #27387, while the square no longer overlaps, it's still very close to the previous line. I think I need to handle margins.
|
|
|
@bors try=wpt-2020 |
|
@bors-servo retry try=wpt-2020 |
bors-servo
added a commit
that referenced
this pull request
Jul 24, 2020
Handle `inset: auto` values for absolutely positioned elements Fixes #27387 I'm not 100% sure of this approach, i don't like reconstructing the vector there. Also, when tried on the testcase in #27387, while the square no longer overlaps, it's still very close to the previous line. I think I need to handle margins.
|
|
Manishearth
changed the title
|
Opened a second version of this PR in #27399, based on @SimonSapin's comments. It's a separate PR because the approaches are pretty different. |
bors-servo
added a commit
that referenced
this pull request
Jul 25, 2020
[Arc version] Handle `inset: auto` values for absolutely positioned elements Fixes #27387 This is the same as #27397 , but written to share the box offset data instead of bubbling the hoisted box up based on comments from @SimonSapin.
|
Closing in favor of #27399 |
bors-servo
added a commit
that referenced
this pull request
Jul 27, 2020
…apin Handle `inset: auto` values for absolutely positioned elements Fixes #27387 This is the same as #27397 , but written to share the box offset data instead of bubbling the hoisted box up based on comments from @SimonSapin.
bors-servo
added a commit
that referenced
this pull request
Jul 27, 2020
…apin Handle `inset: auto` values for absolutely positioned elements Fixes #27387 This is the same as #27397 , but written to share the box offset data instead of bubbling the hoisted box up based on comments from @SimonSapin.
bors-servo
added a commit
that referenced
this pull request
Jul 27, 2020
…apin Handle `inset: auto` values for absolutely positioned elements Fixes #27387 This is the same as #27397 , but written to share the box offset data instead of bubbling the hoisted box up based on comments from @SimonSapin.
bors-servo
added a commit
that referenced
this pull request
Jul 27, 2020
…apin Handle `inset: auto` values for absolutely positioned elements Fixes #27387 This is the same as #27397 , but written to share the box offset data instead of bubbling the hoisted box up based on comments from @SimonSapin.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Manishearth commentedJul 24, 2020
Fixes #27387
I'm not 100% sure of this approach, i don't like reconstructing the
vector there.
Also, when tried on the testcase in #27387, while the square no longer overlaps, it's still very close to the previous line. I think I need to handle margins.