Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle inset: auto values for absolutely positioned elements #27399

Merged
merged 5 commits into from Jul 27, 2020

Conversation

Manishearth
Copy link
Member

@Manishearth Manishearth commented Jul 24, 2020

Fixes #27387

This is the same as #27397 , but written to share the box offset data instead of bubbling the hoisted box up based on comments from @SimonSapin.

@Manishearth
Copy link
Member Author

Manishearth commented Jul 24, 2020

@bors try=wpt-2020

I've already updated expectations, so i'm hoping to see if anything changed between these two PRs.

@Manishearth
Copy link
Member Author

Manishearth commented Jul 25, 2020

@bors-servo try=wpt-2020

@bors-servo
Copy link
Contributor

bors-servo commented Jul 25, 2020

Trying commit ed5dfa7 with merge 60244fc...

bors-servo added a commit that referenced this issue Jul 25, 2020
[Arc version] Handle `inset: auto` values for absolutely positioned elements

Fixes #27387

This is the same as #27397 , but written to share the box offset data instead of bubbling the hoisted box up based on comments from @SimonSapin.
@bors-servo
Copy link
Contributor

bors-servo commented Jul 25, 2020

💔 Test failed - status-taskcluster

@Manishearth
Copy link
Member Author

Manishearth commented Jul 25, 2020

It's the same tests, I just forgot to git add added files.

@bors-servo
Copy link
Contributor

bors-servo commented Jul 25, 2020

The latest upstream changes (presumably #27401) made this pull request unmergeable. Please resolve the merge conflicts.

@SimonSapin
Copy link
Member

SimonSapin commented Jul 27, 2020

Looks good! r=me with a rebase

@Manishearth Manishearth marked this pull request as ready for review Jul 27, 2020
@Manishearth Manishearth force-pushed the auto-abspos-hoist-shared branch from ff5e4ef to 965dded Compare Jul 27, 2020
@Manishearth
Copy link
Member Author

Manishearth commented Jul 27, 2020

@bors-servo r=SimonSapin

@bors-servo
Copy link
Contributor

bors-servo commented Jul 27, 2020

📌 Commit 965dded has been approved by SimonSapin

@Manishearth Manishearth changed the title [Arc version] Handle inset: auto values for absolutely positioned elements Handle inset: auto values for absolutely positioned elements Jul 27, 2020
@bors-servo
Copy link
Contributor

bors-servo commented Jul 27, 2020

Testing commit 965dded with merge 0833cb2...

bors-servo added a commit that referenced this issue Jul 27, 2020
…apin

Handle `inset: auto` values for absolutely positioned elements

Fixes #27387

This is the same as #27397 , but written to share the box offset data instead of bubbling the hoisted box up based on comments from @SimonSapin.
@bors-servo
Copy link
Contributor

bors-servo commented Jul 27, 2020

💔 Test failed - status-taskcluster

@jdm
Copy link
Member

jdm commented Jul 27, 2020

bors-servo added a commit that referenced this issue Jul 27, 2020
…apin

Handle `inset: auto` values for absolutely positioned elements

Fixes #27387

This is the same as #27397 , but written to share the box offset data instead of bubbling the hoisted box up based on comments from @SimonSapin.
@bors-servo
Copy link
Contributor

bors-servo commented Jul 27, 2020

Testing commit 965dded with merge 7ff9e7b...

@bors-servo
Copy link
Contributor

bors-servo commented Jul 27, 2020

💔 Test failed - status-taskcluster

@jdm
Copy link
Member

jdm commented Jul 27, 2020

@bors-servo
Copy link
Contributor

bors-servo commented Jul 27, 2020

Testing commit 965dded with merge c10c4e9...

bors-servo added a commit that referenced this issue Jul 27, 2020
…apin

Handle `inset: auto` values for absolutely positioned elements

Fixes #27387

This is the same as #27397 , but written to share the box offset data instead of bubbling the hoisted box up based on comments from @SimonSapin.
@bors-servo
Copy link
Contributor

bors-servo commented Jul 27, 2020

💔 Test failed - status-taskcluster

@Manishearth
Copy link
Member Author

Manishearth commented Jul 27, 2020

@bors-servo retry

  ▶ FAIL [expected PASS] /css/css-color/t421-rgb-values-meaning-b.xht

@bors-servo
Copy link
Contributor

bors-servo commented Jul 27, 2020

Testing commit 965dded with merge c7bdb1b...

@bors-servo
Copy link
Contributor

bors-servo commented Jul 27, 2020

☀️ Test successful - status-taskcluster
Approved by: SimonSapin
Pushing c7bdb1b to master...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants