Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle `inset: auto` values for absolutely positioned elements #27399

Merged
merged 5 commits into from Jul 27, 2020
Merged

Handle `inset: auto` values for absolutely positioned elements #27399

merged 5 commits into from Jul 27, 2020
+138 −207

Conversation

@Manishearth
Copy link
Member

Manishearth commented Jul 24, 2020

Fixes #27387

This is the same as #27397 , but written to share the box offset data instead of bubbling the hoisted box up based on comments from @SimonSapin.
@Manishearth Manishearth requested a review from SimonSapin Jul 24, 2020
@Manishearth Manishearth mentioned this pull request Jul 24, 2020
Closed
@Manishearth
Copy link
Member Author

Manishearth commented Jul 24, 2020

@bors try=wpt-2020

I've already updated expectations, so i'm hoping to see if anything changed between these two PRs.
@Manishearth
Copy link
Member Author

Manishearth commented Jul 25, 2020

@bors-servo try=wpt-2020
@bors-servo
Copy link
Contributor

bors-servo commented Jul 25, 2020

⌛ Trying commit ed5dfa7 with merge 60244fc...
bors-servo added a commit that referenced this pull request Jul 25, 2020
@bors-servo
Auto merge of #27399 - Manishearth:auto-abspos-hoist-shared, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
60244fc 
[Arc version] Handle `inset: auto` values for absolutely positioned elements

Fixes #27387

This is the same as #27397 , but written to share the box offset data instead of bubbling the hoisted box up based on comments from @SimonSapin.
@bors-servo
Copy link
Contributor

bors-servo commented Jul 25, 2020

💔 Test failed - status-taskcluster
@Manishearth Manishearth force-pushed the Manishearth:auto-abspos-hoist-shared branch from ed5dfa7 to ff5e4ef Jul 25, 2020
@Manishearth
Copy link
Member Author

Manishearth commented Jul 25, 2020

It's the same tests, I just forgot to git add added files.
@bors-servo
Copy link
Contributor

bors-servo commented Jul 25, 2020

☔ The latest upstream changes (presumably #27401) made this pull request unmergeable. Please resolve the merge conflicts.
@SimonSapin
Copy link
Member

SimonSapin commented Jul 27, 2020

Looks good! r=me with a rebase
Manishearth added 5 commits Jul 24, 2020
@Manishearth
Allow adjusting box offsets
96c0c50
@Manishearth
Create HoistedSharedFragment
d476a10
@Manishearth
Move AbsoluteBoxOffsets into HoistedSharedFragment
bc704d8
@Manishearth
Adjust absolute positioned box offsets in flow layout
5a53fb1
@Manishearth
Update tests
Loading status checks…
965dded
@Manishearth Manishearth marked this pull request as ready for review Jul 27, 2020
@Manishearth Manishearth force-pushed the Manishearth:auto-abspos-hoist-shared branch from ff5e4ef to 965dded Jul 27, 2020
@Manishearth
Copy link
Member Author

Manishearth commented Jul 27, 2020

@bors-servo r=SimonSapin
@bors-servo
Copy link
Contributor

bors-servo commented Jul 27, 2020

📌 Commit 965dded has been approved by SimonSapin
@Manishearth Manishearth changed the title [Arc version] Handle `inset: auto` values for absolutely positioned elements Handle `inset: auto` values for absolutely positioned elements Jul 27, 2020
@bors-servo
Copy link
Contributor

bors-servo commented Jul 27, 2020

⌛ Testing commit 965dded with merge 0833cb2...
@bors-servo
Copy link
Contributor

bors-servo commented Jul 27, 2020

💔 Test failed - status-taskcluster
@jdm
Copy link
Member

jdm commented Jul 27, 2020

@bors-servo retry
bors-servo added a commit that referenced this pull request Jul 27, 2020
@bors-servo
Auto merge of #27399 - Manishearth:auto-abspos-hoist-shared, r=SimonS…
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
7ff9e7b 
…apin

Handle `inset: auto` values for absolutely positioned elements

Fixes #27387

This is the same as #27397 , but written to share the box offset data instead of bubbling the hoisted box up based on comments from @SimonSapin.
@bors-servo
Copy link
Contributor

bors-servo commented Jul 27, 2020

⌛ Testing commit 965dded with merge 7ff9e7b...
@bors-servo
Copy link
Contributor

bors-servo commented Jul 27, 2020

💔 Test failed - status-taskcluster
@jdm
Copy link
Member

jdm commented Jul 27, 2020

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Jul 27, 2020

⌛ Testing commit 965dded with merge c10c4e9...
bors-servo added a commit that referenced this pull request Jul 27, 2020
@bors-servo
Auto merge of #27399 - Manishearth:auto-abspos-hoist-shared, r=SimonS…
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
c10c4e9 
…apin

Handle `inset: auto` values for absolutely positioned elements

Fixes #27387

This is the same as #27397 , but written to share the box offset data instead of bubbling the hoisted box up based on comments from @SimonSapin.
@bors-servo
Copy link
Contributor

bors-servo commented Jul 27, 2020

💔 Test failed - status-taskcluster
@Manishearth
Copy link
Member Author

Manishearth commented Jul 27, 2020

@bors-servo retry

  ▶ FAIL [expected PASS] /css/css-color/t421-rgb-values-meaning-b.xht
@bors-servo
Copy link
Contributor

bors-servo commented Jul 27, 2020

⌛ Testing commit 965dded with merge c7bdb1b...
@bors-servo
Copy link
Contributor

bors-servo commented Jul 27, 2020

☀️ Test successful - status-taskcluster
Approved by: SimonSapin
Pushing c7bdb1b to master...
@bors-servo bors-servo merged commit c7bdb1b into servo:master Jul 27, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
This was referenced Jul 27, 2020
Closed
Merged
@SimonSapin SimonSapin mentioned this pull request Jul 27, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimonSapin SimonSapin

Assignees

@SimonSapin SimonSapin

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

<position>: auto does not work
5 participants
@Manishearth @bors-servo @SimonSapin @jdm @highfive
You can’t perform that action at this time.