Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fire mouseenter and mouseleave events #27413

Merged
merged 5 commits into from Jul 31, 2020
Merged

Fire mouseenter and mouseleave events #27413

merged 5 commits into from Jul 31, 2020
+319 −71

Conversation

@utsavoza
Copy link
Contributor

utsavoza commented Jul 27, 2020 •
edited

The PR primarily consists of changes for:

  • Fixing the order in which mousemove events are fired.
  • Firing mouseenter and mouseleave events.
  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #26958
  • There are tests for these changes
@highfive
Copy link

highfive commented Jul 27, 2020

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/document.rs
  • @KiChjang: components/script/dom/document.rs, components/script_traits/lib.rs
@highfive
Copy link

highfive commented Jul 27, 2020

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@utsavoza utsavoza force-pushed the utsavoza:ugo/issue-26958/26-07-2020 branch from da48ee5 to d26b9a5 Jul 27, 2020
@utsavoza utsavoza marked this pull request as ready for review Jul 27, 2020
@jdm
Copy link
Member

jdm commented Jul 27, 2020

r? @nox
@highfive highfive assigned nox and unassigned SimonSapin Jul 27, 2020
utsavoza added 4 commits Jul 26, 2020
@utsavoza
Fix ordering of mousemove event
5fe54b8
@utsavoza
Fire mouseenter and mouseleave events
c235e1e
@utsavoza
Fix comments for handle_mouse_move_event method
da45522
@utsavoza
Do not panic on navigating across documents
Loading status checks…
962e620
@utsavoza utsavoza force-pushed the utsavoza:ugo/issue-26958/26-07-2020 branch from cb849aa to 962e620 Jul 30, 2020
@nox
Copy link
Member

nox commented Jul 30, 2020

The code looks correct but this will probably need changes to the test expectations.

@bors-servo try=wpt
bors-servo added a commit that referenced this pull request Jul 30, 2020
@bors-servo
Auto merge of #27413 - utsavoza:ugo/issue-26958/26-07-2020, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
f1c835a 
Fire mouseenter and mouseleave events

The PR primarily consists of changes for:
- Fixing the order in which `mousemove` events are fired.
- Firing `mouseenter` and `mouseleave` events.
---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #26958
- [ ] There are tests for these changes
@bors-servo
Copy link
Contributor

bors-servo commented Jul 30, 2020

⌛ Trying commit 962e620 with merge f1c835a...
@bors-servo
Copy link
Contributor

bors-servo commented Jul 30, 2020

☀️ Test successful - status-taskcluster
State: approved= try=True
@nox
Copy link
Member

nox commented Jul 30, 2020

Aha, we didn't enable pointerevents tests. You need to add this to tests/wpt/include.ini:

[pointerevents]
  skip: false

You can add it after this stuff to keep things alphabetical:

[permissions]
  skip: false
@jdm
Copy link
Member

jdm commented Jul 30, 2020

I think pointerevents is unrelated to mouse events?
@utsavoza
Add some manual tests for verifying mouse events order
Loading status checks…
de20715
@utsavoza
Copy link
Contributor Author

utsavoza commented Jul 30, 2020 •
edited

I have included some manual tests I'd used to verify mouse events' order.
@nox
Copy link
Member

nox commented Jul 31, 2020

I've checked locally and everything looks good now AFAICT.

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Jul 31, 2020

📌 Commit de20715 has been approved by nox
@bors-servo
Copy link
Contributor

bors-servo commented Jul 31, 2020

⌛ Testing commit de20715 with merge 0021a82...
@bors-servo
Copy link
Contributor

bors-servo commented Jul 31, 2020

☀️ Test successful - status-taskcluster
Approved by: nox
Pushing 0021a82 to master...
@bors-servo bors-servo merged commit 0021a82 into servo:master Jul 31, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nox nox

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Fire mouseenter/mouseleave events
6 participants
@utsavoza @highfive @jdm @nox @bors-servo @SimonSapin
You can’t perform that action at this time.