Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upPlace floats in layout 2020, but don't flow text around the floats yet. #27415
Conversation
highfive
commented
Jul 27, 2020
|
Heads up! This PR modifies the following files:
|
pcwalton
force-pushed the
pcwalton:floats-2020
branch
2 times, most recently
from
e231e1a
to
7fb155a
|
|
pcwalton
force-pushed the
pcwalton:floats-2020
branch
2 times, most recently
from
8d10eb1
to
cba8088
|
|
|
r=me |
|
@bors-servo try=wpt-2020 |
bors-servo
added a commit
that referenced
this pull request
Jul 29, 2020
Place floats in layout 2020, but don't flow text around the floats yet. This commit puts floats behind the `layout.floats.enabled` pref, because of the following issues and unimplemented features: * Inline formatting contexts don't take floats into account, so text doesn't flow around the floats yet. * Non-floated block formatting contexts don't take floats into account, so BFCs can overlap floats. * The `clear` property is only respected on floats, not on other elements; i.e. regular boxes can't clear past floats yet. * Block formatting contexts that contain floats don't expand vertically to contain all the floats. That is, floats can stick out the bottom of BFCs, contra spec. * Floats don't respect negative margins yet. * Floats are painted in the same order as regular content, contra spec. r? @Manishearth <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [ ] These changes fix #___ (GitHub issue number if applicable) <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because ___ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
|
|
@bors-servo try=wpt-2020 |
bors-servo
added a commit
that referenced
this pull request
Jul 29, 2020
Place floats in layout 2020, but don't flow text around the floats yet. This commit puts floats behind the `layout.floats.enabled` pref, because of the following issues and unimplemented features: * Inline formatting contexts don't take floats into account, so text doesn't flow around the floats yet. * Non-floated block formatting contexts don't take floats into account, so BFCs can overlap floats. * The `clear` property is only respected on floats, not on other elements; i.e. regular boxes can't clear past floats yet. * Block formatting contexts that contain floats don't expand vertically to contain all the floats. That is, floats can stick out the bottom of BFCs, contra spec. * Floats don't respect negative margins yet. * Floats are painted in the same order as regular content, contra spec. r? @Manishearth <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [ ] These changes fix #___ (GitHub issue number if applicable) <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because ___ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
|
|
@bors-servo try=wpt-2020 |
bors-servo
added a commit
that referenced
this pull request
Jul 29, 2020
Place floats in layout 2020, but don't flow text around the floats yet. This commit puts floats behind the `layout.floats.enabled` pref, because of the following issues and unimplemented features: * Inline formatting contexts don't take floats into account, so text doesn't flow around the floats yet. * Non-floated block formatting contexts don't take floats into account, so BFCs can overlap floats. * The `clear` property is only respected on floats, not on other elements; i.e. regular boxes can't clear past floats yet. * Block formatting contexts that contain floats don't expand vertically to contain all the floats. That is, floats can stick out the bottom of BFCs, contra spec. * Floats don't respect negative margins yet. * Floats are painted in the same order as regular content, contra spec. r? @Manishearth <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [ ] These changes fix #___ (GitHub issue number if applicable) <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because ___ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
|
|
@bors-servo try=wpt-2020 |
bors-servo
added a commit
that referenced
this pull request
Jul 31, 2020
Place floats in layout 2020, but don't flow text around the floats yet. This commit puts floats behind the `layout.floats.enabled` pref, because of the following issues and unimplemented features: * Inline formatting contexts don't take floats into account, so text doesn't flow around the floats yet. * Non-floated block formatting contexts don't take floats into account, so BFCs can overlap floats. * The `clear` property is only respected on floats, not on other elements; i.e. regular boxes can't clear past floats yet. * Block formatting contexts that contain floats don't expand vertically to contain all the floats. That is, floats can stick out the bottom of BFCs, contra spec. * Floats don't respect negative margins yet. * Floats are painted in the same order as regular content, contra spec. r? @Manishearth <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [ ] These changes fix #___ (GitHub issue number if applicable) <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because ___ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
| @@ -1,4 +1,2 @@ | |||
| [localeCompare.html] | |||
| bug: https://github.com/servo/servo/issues/25802 | |||
| [localeCompare should return the same as other browsers, even though it's implementation-dependent] | |||
| expected: FAIL | |||
This comment has been minimized.
This comment has been minimized.
| @@ -1,4 +1,4 @@ | |||
| [navigator.html] | |||
| [navigator.platform mac] | |||
| [navigator.platform linux] | |||
This comment has been minimized.
This comment has been minimized.
| @@ -0,0 +1,19 @@ | |||
| [promise.html] | |||
| [Resolve callback gets argument] | |||
This comment has been minimized.
This comment has been minimized.
|
|
This commit puts floats behind the `layout.floats.enabled` pref, because of the following issues and unimplemented features: * Inline formatting contexts don't take floats into account, so text doesn't flow around the floats yet. * Non-floated block formatting contexts don't take floats into account, so BFCs can overlap floats. * The `clear` property is only respected on floats, not on other elements; i.e. regular boxes can't clear past floats yet. * Block formatting contexts that contain floats don't expand vertically to contain all the floats. That is, floats can stick out the bottom of BFCs, contra spec. * Floats don't respect negative margins yet. * Floats are painted in the same order as regular content, contra spec.
|
@bors-servo try=wpt-2020 |
bors-servo
added a commit
that referenced
this pull request
Jul 31, 2020
Place floats in layout 2020, but don't flow text around the floats yet. This commit puts floats behind the `layout.floats.enabled` pref, because of the following issues and unimplemented features: * Inline formatting contexts don't take floats into account, so text doesn't flow around the floats yet. * Non-floated block formatting contexts don't take floats into account, so BFCs can overlap floats. * The `clear` property is only respected on floats, not on other elements; i.e. regular boxes can't clear past floats yet. * Block formatting contexts that contain floats don't expand vertically to contain all the floats. That is, floats can stick out the bottom of BFCs, contra spec. * Floats don't respect negative margins yet. * Floats are painted in the same order as regular content, contra spec. r? @Manishearth <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [ ] These changes fix #___ (GitHub issue number if applicable) <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because ___ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
pcwalton commentedJul 27, 2020
•
edited
This commit puts floats behind the
layout.floats.enabledpref, because of thefollowing issues and unimplemented features:
Inline formatting contexts don't take floats into account, so text doesn't
flow around the floats yet.
Non-floated block formatting contexts don't take floats into account, so BFCs
can overlap floats.
The
clearproperty is only respected on floats, not on other elements; i.e.regular boxes can't clear past floats yet.
Block formatting contexts that contain floats don't expand vertically to
contain all the floats. That is, floats can stick out the bottom of BFCs,
contra spec.
Floats don't respect negative margins yet.
Floats are painted in the same order as regular content, contra spec.
r? @Manishearth
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors