Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move secondary view support into a pref #27418

Merged
merged 1 commit into from Jul 28, 2020
Merged

Move secondary view support into a pref #27418

merged 1 commit into from Jul 28, 2020

Conversation

@Manishearth
Copy link
Member

Manishearth commented Jul 28, 2020

Needs servo/webxr#188

Adds a dom.webxr.first_person_observer_view pref that toggles FPO views.
@Manishearth Manishearth requested a review from asajeffrey Jul 28, 2020
@highfive
Copy link

highfive commented Jul 28, 2020

Heads up! This PR modifies the following files:
@highfive
Copy link

highfive commented Jul 28, 2020

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@Manishearth Manishearth mentioned this pull request Jul 28, 2020
Closed
@asajeffrey
Copy link
Member

asajeffrey commented Jul 28, 2020

r=me once the webxr PR lands.
@Manishearth
Move secondary view support into a pref
Loading status checks…
9fe70e6
@Manishearth Manishearth force-pushed the Manishearth:secondary-view-pref branch from 7c8af4b to 9fe70e6 Jul 28, 2020
@Manishearth Manishearth marked this pull request as ready for review Jul 28, 2020
@Manishearth
Copy link
Member Author

Manishearth commented Jul 28, 2020

@bors-servo r=asajeffrey
@bors-servo
Copy link
Contributor

bors-servo commented Jul 28, 2020

📌 Commit 9fe70e6 has been approved by asajeffrey
@bors-servo
Copy link
Contributor

bors-servo commented Jul 28, 2020

⌛ Testing commit 9fe70e6 with merge 870812d...
@bors-servo
Copy link
Contributor

bors-servo commented Jul 28, 2020

☀️ Test successful - status-taskcluster
Approved by: asajeffrey
Pushing 870812d to master...
@bors-servo bors-servo merged commit 870812d into servo:master Jul 28, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asajeffrey asajeffrey

Assignees

@asajeffrey asajeffrey

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@Manishearth @highfive @asajeffrey @bors-servo
You can’t perform that action at this time.