Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unnecessary conversion from UTF-8 to UTF-16 #27420

Merged
merged 1 commit into from Jul 28, 2020

Conversation

avr1254
Copy link
Contributor

@avr1254 avr1254 commented Jul 28, 2020

Changed Spidermonkey API calls to remove need for UTF-16 conversion.


  • There are tests for these changes OR
  • These changes do not require tests because they simply optimize existing code for speed.

@highfive
Copy link

highfive commented Jul 28, 2020

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @asajeffrey (or someone else) soon.

@highfive
Copy link

highfive commented Jul 28, 2020

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/htmlscriptelement.rs, components/script/script_module.rs
  • @KiChjang: components/script/dom/htmlscriptelement.rs, components/script/script_module.rs

@highfive
Copy link

highfive commented Jul 28, 2020

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!

@CYBAI
Copy link
Member

CYBAI commented Jul 28, 2020

@bors-servo try=wpt

bors-servo added a commit that referenced this issue Jul 28, 2020
Removed unnecessary conversion from UTF-8 to UTF-16

<!-- Please describe your changes on the following line: -->
Changed Spidermonkey API calls to remove need for UTF-16 conversion.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #27331 (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because they simply optimize existing code for speed.

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

bors-servo commented Jul 28, 2020

Trying commit 6014710 with merge fd3c483...

@bors-servo
Copy link
Contributor

bors-servo commented Jul 28, 2020

☀️ Test successful - status-taskcluster
State: approved= try=True

@jdm
Copy link
Member

jdm commented Jul 28, 2020

@bors-servo r+

@bors-servo
Copy link
Contributor

bors-servo commented Jul 28, 2020

📌 Commit 6014710 has been approved by jdm

@bors-servo
Copy link
Contributor

bors-servo commented Jul 28, 2020

Testing commit 6014710 with merge 582a7a7...

@bors-servo
Copy link
Contributor

bors-servo commented Jul 28, 2020

☀️ Test successful - status-taskcluster
Approved by: jdm
Pushing 582a7a7 to master...

@bors-servo bors-servo merged commit 582a7a7 into servo:master Jul 28, 2020
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants