Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support preserveDrawingBuffer #27425

Merged
merged 1 commit into from Aug 6, 2020
Merged

Conversation

jdm
Copy link
Member

@jdm jdm commented Jul 28, 2020

Depends on asajeffrey/surfman-chains#9 and servo/webxr#190.


@jdm
Copy link
Member Author

jdm commented Jul 28, 2020

@bors-servo try=wpt

bors-servo added a commit that referenced this issue Jul 28, 2020
Support preserveDrawingBuffer

Depends on asajeffrey/surfman-chains#9 and servo/webxr#190.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #24604
- [x] There are tests for these changes
@bors-servo
Copy link
Contributor

bors-servo commented Jul 28, 2020

Trying commit 16d0cd1 with merge 4353354...

@bors-servo
Copy link
Contributor

bors-servo commented Jul 28, 2020

☀️ Test successful - status-taskcluster
State: approved= try=True

@jdm
Copy link
Member Author

jdm commented Jul 28, 2020

@bors-servo try=wpt-mac retry

@bors-servo
Copy link
Contributor

bors-servo commented Jul 28, 2020

Trying commit 16d0cd1 with merge 15fd7e7...

bors-servo added a commit that referenced this issue Jul 28, 2020
Support preserveDrawingBuffer

Depends on asajeffrey/surfman-chains#9 and servo/webxr#190.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #24604
- [x] There are tests for these changes
@bors-servo
Copy link
Contributor

bors-servo commented Jul 28, 2020

☀️ Test successful - status-taskcluster
State: approved= try=True

@jdm jdm marked this pull request as ready for review Aug 6, 2020
@jdm
Copy link
Member Author

jdm commented Aug 6, 2020

r? @asajeffrey

Copy link
Member

@asajeffrey asajeffrey left a comment

LGTM with the patch sections in Cargo.toml removed, and version bumps of surfman-chains added.

@jdm jdm force-pushed the preserve-draw-buffer branch from 16d0cd1 to a5e488b Compare Aug 6, 2020
@jdm
Copy link
Member Author

jdm commented Aug 6, 2020

@bors-servo r=asajeffrey

@bors-servo
Copy link
Contributor

bors-servo commented Aug 6, 2020

📌 Commit a5e488b has been approved by asajeffrey

@bors-servo
Copy link
Contributor

bors-servo commented Aug 6, 2020

Testing commit a5e488b with merge 6f60bee...

bors-servo added a commit that referenced this issue Aug 6, 2020
Support preserveDrawingBuffer

Depends on asajeffrey/surfman-chains#9 and servo/webxr#190.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #24604
- [x] There are tests for these changes
@bors-servo
Copy link
Contributor

bors-servo commented Aug 6, 2020

💔 Test failed - status-taskcluster

@jdm
Copy link
Member Author

jdm commented Aug 6, 2020

@bors-servo
Copy link
Contributor

bors-servo commented Aug 6, 2020

Testing commit a5e488b with merge 0573e9c...

@bors-servo
Copy link
Contributor

bors-servo commented Aug 6, 2020

☀️ Test successful - status-taskcluster
Approved by: asajeffrey
Pushing 0573e9c to master...

@bors-servo bors-servo merged commit 0573e9c into servo:master Aug 6, 2020
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants