Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd a pref to indicate user intent to enter webxr #27429
Conversation
highfive
commented
Jul 28, 2020
|
Heads up! This PR modifies the following files:
|
highfive
commented
Jul 28, 2020
|
This needs thought about a bit, because it's switching off a security feature. It's needed for scenarios where we're launching straight into webxr, for example from the gstreamer plugin, which has no 2d view. With this pref we can enter hubs using
|
|
@avadacatavra you may have opinions about ^ |
|
Perhaps we should name the pref something scarier? idk. Implementation seems fine by me. |
|
Yeah, I tried to think of an appropriate |
|
override_user_intent? |
|
maybe stick an _unsafe in there |
|
|
|
Yeah, but unsafe_assume_user_intent |
|
We have a winner! |
efaec78
to
89a2c51
|
Renamed the pref. @Manishearth ok'd setting the pref in the gstreamer plugin at https://chat.mozilla.org/#/room/#servo:mozilla.org/$3DTiFVKWr85K322xn49tTBoMtEOvScTFtqi4o5okyA4 @bors-servo r=Manishearth |
|
|
|
|
asajeffrey commentedJul 28, 2020
Add a pref to indicate that the user has indicated intent to enter webxr.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors