Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upDo not lock if GL thread fails #27440
Closed
Conversation
|
Ok, this is subtle enough that I'd like to spend a bit of time testing it on the device to make sure there are no surprises. Let's target it for the next release instead of the one for this week. |
|
r? @jdm |
|
We can skip that PR if it's not for v1.2, as it will be part of #27438. |
|
|
|
This happened in #27438 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
paulrouget commentedJul 29, 2020
This might help sometimes when the GL thread fails.
@jdm as I was mentioning, without this, the whole browser can end up being locked (UI being unresponsive).
With this, Servo stays irresponsive, but the app is not locked.