Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor and improve GPUErrorScopes #27447

Merged
merged 1 commit into from Jul 30, 2020
Merged

Refactor and improve GPUErrorScopes #27447

merged 1 commit into from Jul 30, 2020

Conversation

@kunalmohan
Copy link
Collaborator

kunalmohan commented Jul 29, 2020

  • Remove use of equivalent BGLs
  • Capture errors from more Createxxx operations
  • Address crashes on macOS in #27402

Improved ErrorScope model attempts to-

  1. Identify and report OutOfMemoryError separately.
  2. Match GPUErrorFilter and pass on uncaptured errors to parent scope.

r?@kvark

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #___ (GitHub issue number if applicable)
  • There are tests for these changes OR
  • These changes do not require tests because ___
@highfive
Copy link

highfive commented Jul 29, 2020

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/globalscope.rs, components/script/dom/webidls/GPUTextureView.webidl, components/script/dom/gpurenderbundleencoder.rs, components/script/dom/gpudevice.rs, components/script/dom/bindings/trace.rs and 2 more
  • @KiChjang: components/script/dom/globalscope.rs, components/script/dom/webidls/GPUTextureView.webidl, components/script/dom/gpurenderbundleencoder.rs, components/script/dom/gpudevice.rs, components/script/dom/bindings/trace.rs and 2 more
@highfive
Copy link

highfive commented Jul 29, 2020

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@kunalmohan kunalmohan added this to In progress in WebGPU MVP via automation Jul 29, 2020
@kvark
kvark requested changes Jul 29, 2020
View changes
Copy link
Member

kvark left a comment

Looks good for most parts!
components/script/dom/gputexture.rs Outdated Show resolved Hide resolved
components/webgpu/lib.rs Show resolved Hide resolved
@kunalmohan kunalmohan force-pushed the kunalmohan:gpu-error branch from 479cdd9 to c2ccbf4 Jul 29, 2020
@kunalmohan kunalmohan requested a review from kvark Jul 29, 2020
@kvark
kvark reviewed Jul 29, 2020
View changes
components/script/dom/gputexture.rs Outdated Show resolved Hide resolved
@kunalmohan
Refactor and improve GPUErrorScopes
Loading status checks…
4e38633 
Remove use of equivalent BGLs
@kunalmohan kunalmohan force-pushed the kunalmohan:gpu-error branch from c2ccbf4 to 4e38633 Jul 30, 2020
@kunalmohan kunalmohan requested a review from kvark Jul 30, 2020
@kvark
kvark approved these changes Jul 30, 2020
View changes
@kvark
Copy link
Member

kvark commented Jul 30, 2020

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Jul 30, 2020

📌 Commit 4e38633 has been approved by kvark
@bors-servo
Copy link
Contributor

bors-servo commented Jul 30, 2020

⌛ Testing commit 4e38633 with merge f0ba895...
@bors-servo
Copy link
Contributor

bors-servo commented Jul 30, 2020

☀️ Test successful - status-taskcluster
Approved by: kvark
Pushing f0ba895 to master...
@bors-servo bors-servo merged commit f0ba895 into servo:master Jul 30, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
WebGPU MVP automation moved this from In progress to Done Jul 30, 2020
@kunalmohan kunalmohan deleted the kunalmohan:gpu-error branch Jul 30, 2020
@jdm jdm mentioned this pull request Jul 31, 2020
Merged
4 of 4 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvark kvark

Assignees

@kvark kvark

Labels
None yet
Projects
WebGPU MVP
  
Done
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@kunalmohan @highfive @kvark @bors-servo
You can’t perform that action at this time.