Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't delete GL textures created by WebXR #27448

Merged
merged 1 commit into from Jul 30, 2020

Conversation

asajeffrey
Copy link
Member

@asajeffrey asajeffrey commented Jul 29, 2020

Currently WebGL assumes it owns any WebGLTexture, and deletes the backing GL texture when the object is GC'd. This isn't valid for textures created by a webxr layer manager, which can result in textures being used after they're deleted.


@highfive
Copy link

highfive commented Jul 29, 2020

Heads up! This PR modifies the following files:

  • @KiChjang: components/script/dom/webgltexture.rs, components/script/dom/xrwebgllayer.rs

@highfive
Copy link

highfive commented Jul 29, 2020

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!

jdm
jdm approved these changes Jul 29, 2020
@asajeffrey
Copy link
Member Author

asajeffrey commented Jul 29, 2020

@bors-servo r=jdm

@bors-servo
Copy link
Contributor

bors-servo commented Jul 29, 2020

📌 Commit dfc641d has been approved by jdm

@highfive highfive assigned jdm and unassigned ferjm Jul 29, 2020
@bors-servo
Copy link
Contributor

bors-servo commented Jul 29, 2020

Testing commit dfc641d with merge 5831ab8...

@bors-servo
Copy link
Contributor

bors-servo commented Jul 30, 2020

☀️ Test successful - status-taskcluster
Approved by: jdm
Pushing 5831ab8 to master...

@bors-servo bors-servo merged commit 5831ab8 into servo:master Jul 30, 2020
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants