Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gstreamer plugin README edits #27449

Merged
merged 4 commits into from Jul 30, 2020
Merged

Conversation

@asajeffrey
Copy link
Member

asajeffrey commented Jul 29, 2020

Updated docs to the gstreamer plugin, now with a recipe for streaming to youtube live!


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes do not require tests because we don't test READMEs
! rtmpsink location="rtmp://a.rtmp.youtube.com/live2/x/$TOKEN"
audiotestsrc wave=silence \
! voaacenc bitrate=128000
Comment on lines 59 to 61

This comment has been minimized.

Copy link
@jdm

jdm Jul 29, 2020

Member

There are a couple \s missing on these lines.

This comment has been minimized.

Copy link
@asajeffrey

asajeffrey Jul 29, 2020

Author Member

Fixed.

@asajeffrey asajeffrey force-pushed the asajeffrey:gst-plugin-readme-edits branch from 6941735 to 4d4a9c2 Jul 29, 2020
@jdm
Copy link
Member

jdm commented Jul 29, 2020

@bors-servo
Copy link
Contributor

bors-servo commented Jul 29, 2020

📌 Commit 4d4a9c2 has been approved by jdm

@highfive highfive assigned jdm and unassigned SimonSapin Jul 29, 2020
bors-servo added a commit that referenced this pull request Jul 30, 2020
Gstreamer plugin README edits

<!-- Please describe your changes on the following line: -->

Updated docs to the gstreamer plugin, now with a recipe for streaming to youtube live!

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes do not require tests because we don't test READMEs

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

bors-servo commented Jul 30, 2020

Testing commit 4d4a9c2 with merge 1977b76...

@bors-servo
Copy link
Contributor

bors-servo commented Jul 30, 2020

💔 Test failed - status-taskcluster

@CYBAI
Copy link
Collaborator

CYBAI commented Jul 30, 2020

@bors-servo
Copy link
Contributor

bors-servo commented Jul 30, 2020

Testing commit 4d4a9c2 with merge b1bd409...

@bors-servo
Copy link
Contributor

bors-servo commented Jul 30, 2020

☀️ Test successful - status-taskcluster
Approved by: jdm
Pushing b1bd409 to master...

@bors-servo bors-servo merged commit b1bd409 into servo:master Jul 30, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.