Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upDo not instanciate random ServoControls #27466
Merged
+34
−36
Conversation
|
Happens when we open the devtools for example. |
|
@bors-servo r+ |
|
|
|
@bors-servo p=1 |
bors-servo
added a commit
that referenced
this pull request
Jul 31, 2020
Do not instanciate random ServoControls That's embarrassing. We would create a new instance of Servo every time we would call `ServoControl()` (instead of `servoControl()`)… so very often.
|
|
|
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Jul 31, 2020
Do not instanciate random ServoControls That's embarrassing. We would create a new instance of Servo every time we would call `ServoControl()` (instead of `servoControl()`)… so very often.
|
|
|
|
|
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Jul 31, 2020
Do not instanciate random ServoControls That's embarrassing. We would create a new instance of Servo every time we would call `ServoControl()` (instead of `servoControl()`)… so very often.
|
|
|
@bors-servo retry |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
paulrouget commentedJul 31, 2020
That's embarrassing. We would create a new instance of Servo every time we would call
ServoControl()(instead ofservoControl())… so very often.