Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRefactor compositor layer tree design #2748
Merged
+868
−1,890
Conversation
Instead of having two parallel trees of CompositorLayers and ContainerLayers, transform CompositorLayer to CompositorData and move tiling logic to rust-layers.
hoppipolla-critic-bot
commented
Jul 2, 2014
|
Critic review: https://critic.hoppipolla.co.uk/r/1950 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
|
r? @zwarich |
zwarich
commented
Jul 2, 2014
|
Just adding a note that the corresponding rust-layers change was done in servo/rust-layers#75. |
This comment has been minimized.
This comment has been minimized.
larsbergstrom
commented on 0c2538d
Jul 2, 2014
|
r=zwarich |
larsbergstrom
added a commit
that referenced
this pull request
Jul 2, 2014
Refactor compositor layer tree design
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
mrobinson commentedJul 2, 2014
Instead of having two parallel trees of CompositorLayers and
ContainerLayers, transform CompositorLayer to CompositorData and move
tiling logic to rust-layers.