Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGPU-Report errors in Promise or void returning operations #27480

Merged
merged 4 commits into from Aug 4, 2020

Conversation

kunalmohan
Copy link
Collaborator

@kunalmohan kunalmohan commented Aug 2, 2020

This also updates GPUBuffer mapping to match latest spec.

r?@kvark


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors

@highfive
Copy link

highfive commented Aug 2, 2020

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/gpuadapter.rs, components/script/dom/gpucomputepassencoder.rs, components/script/dom/gpuqueue.rs, components/script/dom/webidls/GPU.webidl, components/script/dom/gpubuffer.rs and 6 more
  • @KiChjang: components/script/dom/gpuadapter.rs, components/script/dom/gpucomputepassencoder.rs, components/script/dom/gpuqueue.rs, components/script/dom/webidls/GPU.webidl, components/script/dom/gpubuffer.rs and 6 more

@highfive
Copy link

highfive commented Aug 2, 2020

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!

@kunalmohan kunalmohan added this to In progress in WebGPU MVP via automation Aug 2, 2020
kvark
kvark approved these changes Aug 2, 2020
components/webgpu/lib.rs Outdated Show resolved Hide resolved
And extract it from WebGPURequest
@kunalmohan kunalmohan requested a review from kvark Aug 2, 2020
kvark
kvark approved these changes Aug 2, 2020
@jdm
Copy link
Member

jdm commented Aug 4, 2020

@bors-servo r=kvark

@bors-servo
Copy link
Contributor

bors-servo commented Aug 4, 2020

📌 Commit ce6e09a has been approved by kvark

@bors-servo
Copy link
Contributor

bors-servo commented Aug 4, 2020

Testing commit ce6e09a with merge bd57bb4...

bors-servo added a commit that referenced this issue Aug 4, 2020
WebGPU-Report errors in Promise or void returning operations

<!-- Please describe your changes on the following line: -->
This also updates GPUBuffer mapping to match latest spec.

r?@kvark

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 4, 2020

💔 Test failed - status-taskcluster

@jdm
Copy link
Member

jdm commented Aug 4, 2020

@bors-servo retry

  • network hiccough

@bors-servo
Copy link
Contributor

bors-servo commented Aug 4, 2020

Testing commit ce6e09a with merge 338ed68...

bors-servo added a commit that referenced this issue Aug 4, 2020
WebGPU-Report errors in Promise or void returning operations

<!-- Please describe your changes on the following line: -->
This also updates GPUBuffer mapping to match latest spec.

r?@kvark

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 4, 2020

💔 Test failed - status-taskcluster

@kunalmohan
Copy link
Collaborator Author

kunalmohan commented Aug 4, 2020

Looks like CI doesn't want any more of my PRs to get merged 😆

@jdm
Copy link
Member

jdm commented Aug 4, 2020

@bors-servo retry

bors-servo added a commit that referenced this issue Aug 4, 2020
WebGPU-Report errors in Promise or void returning operations

<!-- Please describe your changes on the following line: -->
This also updates GPUBuffer mapping to match latest spec.

r?@kvark

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 4, 2020

Testing commit ce6e09a with merge 87d95db...

@bors-servo
Copy link
Contributor

bors-servo commented Aug 4, 2020

💔 Test failed - status-taskcluster

@jdm
Copy link
Member

jdm commented Aug 4, 2020

@bors-servo
Copy link
Contributor

bors-servo commented Aug 4, 2020

Testing commit ce6e09a with merge 9f43815...

bors-servo added a commit that referenced this issue Aug 4, 2020
WebGPU-Report errors in Promise or void returning operations

<!-- Please describe your changes on the following line: -->
This also updates GPUBuffer mapping to match latest spec.

r?@kvark

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 4, 2020

☀️ Test successful - status-taskcluster
Approved by: kvark
Pushing 9f43815 to master...

@bors-servo
Copy link
Contributor

bors-servo commented Aug 4, 2020

👀 Test was successful, but fast-forwarding failed: 422 Update is not a fast forward

@jdm
Copy link
Member

jdm commented Aug 4, 2020

@bors-servo retry

@bors-servo
Copy link
Contributor

bors-servo commented Aug 4, 2020

Testing commit ce6e09a with merge 549179b...

@bors-servo
Copy link
Contributor

bors-servo commented Aug 4, 2020

☀️ Test successful - status-taskcluster
Approved by: kvark
Pushing 549179b to master...

@bors-servo bors-servo merged commit 549179b into servo:master Aug 4, 2020
2 checks passed
WebGPU MVP automation moved this from In progress to Done Aug 4, 2020
@kunalmohan kunalmohan deleted the gpu-void-error branch Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
WebGPU MVP
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants