Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebXR Layers update WebIDL #27487

Merged
merged 3 commits into from Aug 4, 2020
Merged

WebXR Layers update WebIDL #27487

merged 3 commits into from Aug 4, 2020

Conversation

@asajeffrey
Copy link
Member

asajeffrey commented Aug 3, 2020

Updates the WebXR Layers WebIDL. Implements the "update the pending layers state" algorithm from the layer spec.

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • There are updated tests for these changes
asajeffrey added 2 commits Jul 31, 2020
@asajeffrey
Update WebXR Layer IDL, and matching changes to the Rust code.
bf7f4ea
@asajeffrey
Implement the changes to updating the render state from the WebXR Lay…
31de347 
…ers spec
@highfive
Copy link

highfive commented Aug 3, 2020

Heads up! This PR modifies the following files:

  • @KiChjang: components/script/dom/webidls/XRLayerEvent.webidl, components/script/dom/xrrenderstate.rs, components/script/dom/webidls/XRLayer.webidl, components/script/dom/webidls/XRSubImage.webidl, components/script/dom/webidls/XRMediaBinding.webidl and 8 more
@asajeffrey asajeffrey mentioned this pull request Aug 3, 2020
Open
5 of 17 tasks complete
@asajeffrey
Copy link
Member Author

asajeffrey commented Aug 3, 2020

r? @Manishearth
@highfive highfive assigned Manishearth and unassigned nox Aug 3, 2020
@Manishearth
Copy link
Member

Manishearth commented Aug 3, 2020

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Aug 3, 2020

📌 Commit e1bc706 has been approved by Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented Aug 3, 2020

⌛ Testing commit e1bc706 with merge 7aa1b18...
bors-servo added a commit that referenced this pull request Aug 3, 2020
@bors-servo
Auto merge of #27487 - asajeffrey:webxr-update-webidl, r=Manishearth
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
7aa1b18 
WebXR Layers update WebIDL

<!-- Please describe your changes on the following line: -->

Updates the WebXR Layers WebIDL. Implements the "update the pending layers state" algorithm from the layer spec.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] There are updated tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 4, 2020

💔 Test failed - status-taskcluster
@CYBAI
Copy link
Collaborator

CYBAI commented Aug 4, 2020 

  ▶ Unexpected subtest result in /_mozilla/mozilla/interfaces.html:
  │ FAIL [expected PASS] Interfaces exposed on the window
  │   → assert_true: If this is failing: DANGER, are you sure you want to expose the new interface XRLayer to all webpages as a property on the global? Do not make a change to this file without review from jdm or Ms2ger for that specific change! expected true got false
  │ 
  │ test_interfaces/<@http://web-platform.test:8000/_mozilla/mozilla/interfaces.js:77:18
  │ Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1977:25
  │ test@http://web-platform.test:8000/resources/testharness.js:535:30
  │ test_interfaces@http://web-platform.test:8000/_mozilla/mozilla/interfaces.js:2:7
  └ @http://web-platform.test:8000/_mozilla/mozilla/interfaces.html:13:16
@asajeffrey
Updated wpt
Loading status checks…
9e55c87
@asajeffrey asajeffrey force-pushed the asajeffrey:webxr-update-webidl branch from e1bc706 to 9e55c87 Aug 4, 2020
@asajeffrey
Copy link
Member Author

asajeffrey commented Aug 4, 2020

Change to interfaces.html okayed by @jdm https://chat.mozilla.org/#/room/#servo:mozilla.org/$vsyxKtUTmCUgGzu0nKVJYaZ3Lj9T9n0vh7V9PzuPzGc

@bors-servo r=Manishearth,jdm
@bors-servo
Copy link
Contributor

bors-servo commented Aug 4, 2020

📌 Commit 9e55c87 has been approved by Manishearth,jdm
@bors-servo
Copy link
Contributor

bors-servo commented Aug 4, 2020

⌛ Testing commit 9e55c87 with merge 286793c...
@bors-servo
Copy link
Contributor

bors-servo commented Aug 4, 2020

☀️ Test successful - status-taskcluster
Approved by: Manishearth,jdm
Pushing 286793c to master...
@bors-servo bors-servo merged commit 286793c into servo:master Aug 4, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Manishearth Manishearth

Labels
A-content/script A-xr-zomg
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@asajeffrey @highfive @Manishearth @bors-servo @CYBAI @nox
You can’t perform that action at this time.