Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UWP: only show promoted preferences #27491

Merged
merged 1 commit into from Aug 5, 2020

Conversation

paulrouget
Copy link
Contributor

@paulrouget paulrouget commented Aug 4, 2020

This depends on changes made in #27438
Fix #27419

@highfive
Copy link

highfive commented Aug 4, 2020

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!

<data name="dom.webrtc.enabled"><value>Enable WebRTC</value></data>
<data name="dom.webrtc.transceiver.enabled"><value>WebRTC: Enable transceiver</value></data>
Copy link
Member

@jdm jdm Aug 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't highlight these, since we don't have a UWP backend implementation yet at all.

jdm
jdm approved these changes Aug 4, 2020
@paulrouget
Copy link
Contributor Author

paulrouget commented Aug 5, 2020

@bors-servo r=jdm

@bors-servo
Copy link
Contributor

bors-servo commented Aug 5, 2020

📋 Looks like this PR is still in progress, ignoring approval

@highfive highfive assigned jdm and unassigned SimonSapin Aug 5, 2020
@paulrouget paulrouget changed the title WIP: UWP: only show promoted preferences UWP: only show promoted preferences Aug 5, 2020
@paulrouget
Copy link
Contributor Author

paulrouget commented Aug 5, 2020

@bors-servo r=jdm

@bors-servo
Copy link
Contributor

bors-servo commented Aug 5, 2020

📌 Commit a019db6 has been approved by jdm

@bors-servo
Copy link
Contributor

bors-servo commented Aug 5, 2020

Testing commit a019db6 with merge 7b6bcee...

bors-servo added a commit that referenced this issue Aug 5, 2020
UWP: only show promoted preferences

This depends on changes made in #27438
Fix #27419
@bors-servo
Copy link
Contributor

bors-servo commented Aug 5, 2020

💔 Test failed - status-taskcluster

@paulrouget
Copy link
Contributor Author

paulrouget commented Aug 5, 2020

@bors-servo
Copy link
Contributor

bors-servo commented Aug 5, 2020

Testing commit a019db6 with merge 1b1e6ef...

bors-servo added a commit that referenced this issue Aug 5, 2020
UWP: only show promoted preferences

This depends on changes made in #27438
Fix #27419
@bors-servo
Copy link
Contributor

bors-servo commented Aug 5, 2020

💔 Test failed - status-taskcluster

@jdm
Copy link
Member

jdm commented Aug 5, 2020

@bors-servo retry

@bors-servo
Copy link
Contributor

bors-servo commented Aug 5, 2020

Testing commit a019db6 with merge 611c57b...

@bors-servo
Copy link
Contributor

bors-servo commented Aug 5, 2020

☀️ Test successful - status-taskcluster
Approved by: jdm
Pushing 611c57b to master...

@bors-servo bors-servo merged commit 611c57b into servo:master Aug 5, 2020
2 checks passed
<resheader name="writer">
<value>System.Resources.ResXResourceWriter, System.Windows.Forms, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089</value>
</resheader>
<data name="dom.webxr.hands.enabled"><value>WebXR: Enable XRJointPose (hands joints positions)</value></data>
Copy link
Member

@Manishearth Manishearth Aug 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would call this "enable XRHand" or "enable articulated hand input"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants