UWP: only show promoted preferences #27491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jdm
reviewed
Aug 4, 2020
Comment on lines
125
to
126
| <data name="dom.webrtc.enabled"><value>Enable WebRTC</value></data> | ||
| <data name="dom.webrtc.transceiver.enabled"><value>WebRTC: Enable transceiver</value></data> |
There was a problem hiding this comment.
We shouldn't highlight these, since we don't have a UWP backend implementation yet at all.
jdm
approved these changes
Aug 4, 2020
paulrouget
force-pushed
the
devPreviewTab
branch
from
9c976a8
to
a019db6
Compare
|
@bors-servo r=jdm |
|
📋 Looks like this PR is still in progress, ignoring approval |
paulrouget
changed the title
|
@bors-servo r=jdm |
|
📌 Commit a019db6 has been approved by |
highfive
added
S-awaiting-merge
|
💔 Test failed - status-taskcluster |
highfive
added
S-tests-failed
highfive
added
S-awaiting-merge
|
💔 Test failed - status-taskcluster |
highfive
added
S-tests-failed
|
@bors-servo retry |
highfive
added
S-awaiting-merge
|
☀️ Test successful - status-taskcluster |
highfive
removed
the
S-awaiting-merge
Manishearth
approved these changes
Aug 5, 2020
| <resheader name="writer"> | ||
| <value>System.Resources.ResXResourceWriter, System.Windows.Forms, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089</value> | ||
| </resheader> | ||
| <data name="dom.webxr.hands.enabled"><value>WebXR: Enable XRJointPose (hands joints positions)</value></data> |
There was a problem hiding this comment.
I would call this "enable XRHand" or "enable articulated hand input"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This depends on changes made in #27438
Fix #27419