Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dummy implementations of missing XR layer types #27499

Merged
merged 3 commits into from Aug 5, 2020
Merged

Add dummy implementations of missing XR layer types #27499

merged 3 commits into from Aug 5, 2020
+367 −89

Conversation

@asajeffrey
Copy link
Member

asajeffrey commented Aug 4, 2020

Add dummy implementations of the missing layer types, and the functions that create them.

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • There are tests for these changes
asajeffrey added 3 commits Aug 4, 2020
@asajeffrey
Add test for layers feature (currently always false)
754019f
@asajeffrey
Add a dummy implementation of all the XR Layer types
d255dc9
@asajeffrey
Add tests for layer creation failing
Loading status checks…
a2fa556
@asajeffrey asajeffrey added the A-xr-zomg label Aug 4, 2020
@highfive
Copy link

highfive commented Aug 4, 2020

Heads up! This PR modifies the following files:

  • @KiChjang: components/script/dom/xrcylinderlayer.rs, components/script/dom/xrquadlayer.rs, components/script/dom/xrequirectlayer.rs, components/script/dom/webidls/XRLayer.webidl, components/script/dom/xrcompositionlayer.rs and 14 more
@asajeffrey
Copy link
Member Author

asajeffrey commented Aug 4, 2020

r? @Manishearth
@highfive highfive assigned Manishearth and unassigned SimonSapin Aug 4, 2020
@asajeffrey asajeffrey changed the title Webxr xrmedia dummy Add dummy implementations of missing XR layer types Aug 4, 2020
@asajeffrey asajeffrey mentioned this pull request Aug 4, 2020
Open
5 of 17 tasks complete
@Manishearth
Copy link
Member

Manishearth commented Aug 4, 2020

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Aug 4, 2020

📌 Commit a2fa556 has been approved by Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented Aug 4, 2020

⌛ Testing commit a2fa556 with merge f8c8307...
@bors-servo
Copy link
Contributor

bors-servo commented Aug 5, 2020

☀️ Test successful - status-taskcluster
Approved by: Manishearth
Pushing f8c8307 to master...
@bors-servo bors-servo merged commit f8c8307 into servo:master Aug 5, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Manishearth Manishearth

Labels
A-xr-zomg
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@asajeffrey @highfive @Manishearth @bors-servo @SimonSapin
You can’t perform that action at this time.