Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep C++ pref value in memory longer #27506

Merged
merged 1 commit into from Aug 5, 2020

Conversation

@paulrouget
Copy link
Contributor

paulrouget commented Aug 5, 2020

No description provided.

@jdm
Copy link
Member

jdm commented Aug 5, 2020

@bors-servo r+
This looks ok as a stop-gap solution for memory corruption. I look forward to replacing these with a pervasive solution for passing pointers to embedder-allocated memory that is deallocated when the engine no longer needs it.

@bors-servo
Copy link
Contributor

bors-servo commented Aug 5, 2020

📌 Commit 3b87739 has been approved by jdm

@highfive highfive assigned jdm and unassigned Manishearth Aug 5, 2020
@bors-servo
Copy link
Contributor

bors-servo commented Aug 5, 2020

Testing commit 3b87739 with merge 90aa0a3...

@bors-servo
Copy link
Contributor

bors-servo commented Aug 5, 2020

☀️ Test successful - status-taskcluster
Approved by: jdm
Pushing 90aa0a3 to master...

@bors-servo bors-servo merged commit 90aa0a3 into servo:master Aug 5, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.