Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add XRLayerEvent #27513

Merged
merged 1 commit into from Aug 6, 2020
Merged

Add XRLayerEvent #27513

merged 1 commit into from Aug 6, 2020
+112 −6

Conversation

@asajeffrey
Copy link
Member

asajeffrey commented Aug 5, 2020

Implement the XRLayerEvent spec.

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • There are tests for these changes
@highfive
Copy link

highfive commented Aug 5, 2020

Heads up! This PR modifies the following files:

  • @KiChjang: components/script/dom/webidls/XRLayerEvent.webidl, components/script/dom/xrlayerevent.rs, components/script/dom/mod.rs
@asajeffrey
Copy link
Member Author

asajeffrey commented Aug 5, 2020

r? @Manishearth
@highfive highfive assigned Manishearth and unassigned ferjm Aug 5, 2020
@asajeffrey asajeffrey mentioned this pull request Aug 5, 2020
Open
5 of 17 tasks complete
@Manishearth
Copy link
Member

Manishearth commented Aug 5, 2020

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Aug 5, 2020

📌 Commit 4e97dbf has been approved by Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented Aug 5, 2020

⌛ Testing commit 4e97dbf with merge b8e54a1...
bors-servo added a commit that referenced this pull request Aug 5, 2020
@bors-servo
Auto merge of #27513 - asajeffrey:webxr-layer-event, r=Manishearth
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
b8e54a1 
Add XRLayerEvent

<!-- Please describe your changes on the following line: -->

Implement the `XRLayerEvent` spec.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 5, 2020

💔 Test failed - status-taskcluster
@asajeffrey
Copy link
Member Author

asajeffrey commented Aug 5, 2020

Oops, forgot to hide the interface behind a pref. Yay testing!

1 unexpected results that are NOT known-intermittents:
  ▶ Unexpected subtest result in /_mozilla/mozilla/interfaces.html:
  │ FAIL [expected PASS] Interfaces exposed on the window
  │   → assert_true: If this is failing: DANGER, are you sure you want to expose the new interface XRLayerEvent to all webpages as a property on the global? Do not make a change to this file without review from jdm or Ms2ger for that specific change! expected true got false
  │ 
  │ test_interfaces/<@http://web-platform.test:8000/_mozilla/mozilla/interfaces.js:77:18
  │ Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1977:25
  │ test@http://web-platform.test:8000/resources/testharness.js:535:30
  │ test_interfaces@http://web-platform.test:8000/_mozilla/mozilla/interfaces.js:2:7
  └ @http://web-platform.test:8000/_mozilla/mozilla/interfaces.html:13:16
@asajeffrey
Add XRLayerEvent
Loading status checks…
c4dd171
@asajeffrey asajeffrey force-pushed the asajeffrey:webxr-layer-event branch from 4e97dbf to c4dd171 Aug 5, 2020
@asajeffrey
Copy link
Member Author

asajeffrey commented Aug 5, 2020

@bors-servo r=Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented Aug 5, 2020

📌 Commit c4dd171 has been approved by Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented Aug 5, 2020

⌛ Testing commit c4dd171 with merge 8702be6...
bors-servo added a commit that referenced this pull request Aug 5, 2020
@bors-servo
Auto merge of #27513 - asajeffrey:webxr-layer-event, r=Manishearth
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
8702be6 
Add XRLayerEvent

<!-- Please describe your changes on the following line: -->

Implement the `XRLayerEvent` spec.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 5, 2020

💔 Test failed - status-taskcluster
@jdm
Copy link
Member

jdm commented Aug 6, 2020

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Aug 6, 2020

⌛ Testing commit c4dd171 with merge 39c3f46...
@bors-servo
Copy link
Contributor

bors-servo commented Aug 6, 2020

☀️ Test successful - status-taskcluster
Approved by: Manishearth
Pushing 39c3f46 to master...
@bors-servo bors-servo merged commit 39c3f46 into servo:master Aug 6, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Manishearth Manishearth

Labels
A-content/script A-xr-zomg
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@asajeffrey @highfive @Manishearth @bors-servo @jdm @ferjm
You can’t perform that action at this time.