Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Draft] Lay out floats and handle clearance in layout 2020, but don't flow text around them yet. #27539

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pcwalton
Copy link
Contributor

@pcwalton pcwalton commented Aug 7, 2020


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #___ (GitHub issue number if applicable)
  • There are tests for these changes OR
  • These changes do not require tests because ___

@highfive
Copy link

highfive commented Aug 7, 2020

Heads up! This PR modifies the following files:

  • @emilio: components/style/properties/longhands/box.mako.rs, components/style/values/computed/length.rs

@pcwalton pcwalton marked this pull request as draft Aug 7, 2020
@pcwalton
Copy link
Contributor Author

pcwalton commented Aug 7, 2020

@bors-servo try=wpt-2020

bors-servo added a commit that referenced this issue Aug 7, 2020
[Draft] Lay out floats and handle clearance in layout 2020, but don't flow text around them yet.

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #___ (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 7, 2020

Trying commit 68eb845 with merge c63c458...

@pcwalton
Copy link
Contributor Author

pcwalton commented Aug 7, 2020

@bors-servo try=wpt-2020

bors-servo added a commit that referenced this issue Aug 7, 2020
[Draft] Lay out floats and handle clearance in layout 2020, but don't flow text around them yet.

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #___ (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 7, 2020

Trying commit db43d70 with merge 7e210f9...

@pcwalton
Copy link
Contributor Author

pcwalton commented Aug 7, 2020

(sorry about forgetting to rustfmt)

@bors-servo
Copy link
Contributor

bors-servo commented Aug 7, 2020

💔 Test failed - status-taskcluster

@pcwalton
Copy link
Contributor Author

pcwalton commented Aug 7, 2020

@bors-servo try=wpt-2020

@bors-servo
Copy link
Contributor

bors-servo commented Aug 7, 2020

Trying commit d6d0b88 with merge 0b95e47...

bors-servo added a commit that referenced this issue Aug 7, 2020
[Draft] Lay out floats and handle clearance in layout 2020, but don't flow text around them yet.

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #___ (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 7, 2020

💔 Test failed - status-taskcluster

@pcwalton
Copy link
Contributor Author

pcwalton commented Aug 7, 2020

@bors-servo retry

@bors-servo
Copy link
Contributor

bors-servo commented Aug 7, 2020

Trying commit d6d0b88 with merge 7a9310b...

bors-servo added a commit that referenced this issue Aug 7, 2020
[Draft] Lay out floats and handle clearance in layout 2020, but don't flow text around them yet.

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #___ (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 7, 2020

💔 Test failed - status-taskcluster

@pcwalton pcwalton force-pushed the sequential-context-2020 branch from d6d0b88 to 2e859fa Compare Aug 7, 2020
@pcwalton pcwalton force-pushed the sequential-context-2020 branch 3 times, most recently from 823f152 to 88f6305 Compare Aug 8, 2020
@bors-servo
Copy link
Contributor

bors-servo commented Aug 8, 2020

The latest upstream changes (presumably #27550) made this pull request unmergeable. Please resolve the merge conflicts.

This commit puts floats behind the `layout.floats.enabled` pref, because of the
following issues and unimplemented features:

* Inline formatting contexts don't take floats into account, so text doesn't
  flow around the floats yet.

* Non-floated block formatting contexts don't take floats into account, so BFCs
  can overlap floats.

* Block formatting contexts that contain floats don't expand vertically to
  contain all the floats. That is, floats can stick out the bottom of BFCs,
  contra spec.
@pcwalton pcwalton force-pushed the sequential-context-2020 branch from 88f6305 to 62285b0 Compare Aug 10, 2020
@pcwalton
Copy link
Contributor Author

pcwalton commented Aug 10, 2020

@bors-servo try=wpt-2020

@bors-servo
Copy link
Contributor

bors-servo commented Aug 10, 2020

Trying commit 62285b0 with merge ab042ad...

bors-servo added a commit that referenced this issue Aug 10, 2020
[Draft] Lay out floats and handle clearance in layout 2020, but don't flow text around them yet.

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #___ (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 10, 2020

☀️ Test successful - status-taskcluster
State: approved= try=True

@pcwalton
Copy link
Contributor Author

pcwalton commented Aug 10, 2020

I…did not expect that to pass!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants