Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UWP Bookmarks #27556

Merged
merged 2 commits into from Aug 10, 2020
Merged

UWP Bookmarks #27556

merged 2 commits into from Aug 10, 2020

Conversation

paulrouget
Copy link
Contributor

@paulrouget paulrouget commented Aug 10, 2020

Fix #27416

Bookmarks are saved in a JSON file.
Clicking on the star icon add the bookmark and show a UI to edit the label or cancel the bookmark addition.
Clicking on the star icon again allows the user to edit or remove the bookmark.
A bookmark toolbar is displayed if there's any bookmark.

Screen Shot 2020-08-10 at 15 26 53

Screen Shot 2020-08-10 at 15 26 42

@jdm
Copy link
Member

jdm commented Aug 10, 2020

@bors-servo r+
Looks great! Thanks for implementing this!

@bors-servo
Copy link
Contributor

bors-servo commented Aug 10, 2020

📌 Commit 47fde31 has been approved by jdm

@bors-servo
Copy link
Contributor

bors-servo commented Aug 10, 2020

Testing commit 47fde31 with merge fb597cf...

bors-servo added a commit that referenced this issue Aug 10, 2020
UWP Bookmarks

Fix #27416

Bookmarks are saved in a JSON file.
Clicking on the star icon add the bookmark and show a UI to edit the label or cancel the bookmark addition.
Clicking on the star icon again allows the user to edit or remove the bookmark.
A bookmark toolbar is displayed if there's any bookmark.

<img width="471" alt="Screen Shot 2020-08-10 at 15 26 53" src="https://user-images.githubusercontent.com/373579/89791113-22a81300-db23-11ea-9d1a-9d90e1e62534.png">
<img width="978" alt="Screen Shot 2020-08-10 at 15 26 42" src="https://user-images.githubusercontent.com/373579/89791121-250a6d00-db23-11ea-9b42-6c155ccb2b42.png">
@bors-servo
Copy link
Contributor

bors-servo commented Aug 10, 2020

💔 Test failed - status-taskcluster

@jdm
Copy link
Member

jdm commented Aug 10, 2020

@bors-servo
Copy link
Contributor

bors-servo commented Aug 10, 2020

Testing commit 47fde31 with merge 3cd6b71...

@bors-servo
Copy link
Contributor

bors-servo commented Aug 10, 2020

☀️ Test successful - status-taskcluster
Approved by: jdm
Pushing 3cd6b71 to master...

@bors-servo bors-servo merged commit 3cd6b71 into servo:master Aug 10, 2020
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants