Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate wgpu and WebGPU CTS to include copy validation tests #27590
+2,406
−393
Conversation
highfive
commented
Aug 16, 2020
|
Heads up! This PR modifies the following files:
|
|
@bors-servo try=wpt-mac Let's see if there are any unexpected crashes on macOS in the new tests. |
bors-servo
added a commit
that referenced
this pull request
Aug 16, 2020
Update wgpu and WebGPU CTS to include copy validation tests <!-- Please describe your changes on the following line: --> r?@kvark --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors <!-- Either: --> - [X] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
@kvark Only the first commit is worth reviewing, rest is just copy-paste of new tests. |
|
|
| wgt::TextureUsage::from_bits(descriptor.usage).map(|usg| wgt::TextureDescriptor { | ||
| label: descriptor.parent.label.as_ref().map(|s| s.to_string()), | ||
| wgt::TextureUsage::from_bits(descriptor.usage).map(|usg| wgpu_res::TextureDescriptor { | ||
| label: descriptor |
This comment has been minimized.
This comment has been minimized.
kvark
Aug 16, 2020
Member
it looks like you could benefit from a small helper function to get that label
| format: convert_texture_format(format), | ||
| dimension: convert_texture_view_dimension(dimension), | ||
| .map(|l| Cow::Owned(l.to_string())), | ||
| format: descriptor.format.map(|fr| convert_texture_format(fr)), |
This comment has been minimized.
This comment has been minimized.
| format: descriptor.format.map(|fr| convert_texture_format(fr)), | ||
| dimension: descriptor | ||
| .dimension | ||
| .map(|dm| convert_texture_view_dimension(dm)), |
This comment has been minimized.
This comment has been minimized.
|
notes can be addressed in a follow-up :) |
|
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
kunalmohan commentedAug 16, 2020
r?@kvark
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors