Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUse fixed number of threads and sequential mode for reftests #2766
Conversation
hoppipolla-critic-bot
commented
Jul 4, 2014
|
Critic review: https://critic.hoppipolla.co.uk/r/1975 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
highfive
commented
Jul 4, 2014
|
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @larsbergstrom (or someone else) soon. |
|
…tead of reftest
|
Looks good to me, but I'll kick this review over to @metajack and/or @larsbergstrom because it's makefile changes. |
|
I'm sort of concerned that we would now be asking people to run all of the ref tests 4 times. Maybe we should:
@metajack do you have an opinion? |
|
@metajack Can we make a decision here? The age of this PR is embarrassing. |
|
Since we don't use makefiles anymore, this will have to be redone as mach changes and saltfs changes for buildbot. I think the thing to do would be to add I'm not sure we have to run reftests four times, but if we want coverage of most cases, we will have to run them with and without parallelism. So the buildbot change would involve a new test-ref build step that passed |
|
Ok, let's close this PR and move that decision into the associated issues. |
jviereck commentedJul 4, 2014
This fixes #1975 and #2577.
The reference tests use now 4 threads for rendering and layout. The number is quite random. In terms of performance it would be better to choose the thread number based on the given hardware, but on the other hand a fixed number might make the tests more reproduceable. I went with the later.
Also, this PR addes new
check-ref-cpu-sequentialandcheck-ref-gpu-sequentialmake/test targets, which will run the tests with only one layout and render thread.