Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a `task_info` crate and a `task_basic_info` module within it. #2786

Merged
merged 1 commit into from Jul 9, 2014

Conversation

@nnethercote
Copy link
Contributor

@nnethercote nnethercote commented Jul 8, 2014

The crate provides an interface to the Mac-specific task_info()
function in general, and the module provides an interface to the
TASK_BASIC_INFO flavor. Currently only the virtual_size and
resident_size values of the task_basic_info struct are exposed, but
there's obvious room for expansion.

This is used to implement the -m measurements on Mac.

The crate provides an interface to the Mac-specific `task_info()`
function in general, and the module provides an interface to the
TASK_BASIC_INFO flavor.  Currently only the `virtual_size` and
`resident_size` values of the `task_basic_info` struct are exposed, but
there's obvious room for expansion.

This is used to implement the -m measurements on Mac.
@highfive
Copy link

@highfive highfive commented Jul 8, 2014

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
@hoppipolla-critic-bot
Copy link

@hoppipolla-critic-bot hoppipolla-critic-bot commented Jul 8, 2014

Critic review: https://critic.hoppipolla.co.uk/r/1990

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@pcwalton
Copy link
Contributor

@pcwalton pcwalton commented Jul 9, 2014

Did we decide not to make this a submodule? Anyway, r+

pcwalton added a commit that referenced this pull request Jul 9, 2014
Add a `task_info` crate and a `task_basic_info` module within it.
@pcwalton pcwalton merged commit 94909f2 into servo:master Jul 9, 2014
1 check passed
1 check passed
continuous-integration/travis-ci The Travis CI build passed
Details
@nnethercote
Copy link
Contributor Author

@nnethercote nnethercote commented Jul 9, 2014

Thanks for merging.

Did we decide not to make this a submodule?

In #2720 you suggested an instrumentation module, which I didn't end up doing because "I couldn't work out how to create a new module, and it also felt like overkill." It could certainly be done as a follow-up if necessary.

@nnethercote nnethercote deleted the nnethercote:task_info branch Mar 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.