Add a `task_info` crate and a `task_basic_info` module within it. #2786

Merged
merged 1 commit into from Jul 9, 2014

Conversation

Projects
None yet
4 participants
@nnethercote
Contributor

nnethercote commented Jul 8, 2014

The crate provides an interface to the Mac-specific task_info()
function in general, and the module provides an interface to the
TASK_BASIC_INFO flavor. Currently only the virtual_size and
resident_size values of the task_basic_info struct are exposed, but
there's obvious room for expansion.

This is used to implement the -m measurements on Mac.

Add a `task_info` crate and a `task_basic_info` module within it.
The crate provides an interface to the Mac-specific `task_info()`
function in general, and the module provides an interface to the
TASK_BASIC_INFO flavor.  Currently only the `virtual_size` and
`resident_size` values of the `task_basic_info` struct are exposed, but
there's obvious room for expansion.

This is used to implement the -m measurements on Mac.
@highfive

This comment has been minimized.

Show comment
Hide comment
@highfive

highfive Jul 8, 2014

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!

highfive commented Jul 8, 2014

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
@hoppipolla-critic-bot

This comment has been minimized.

Show comment
Hide comment
@hoppipolla-critic-bot

hoppipolla-critic-bot Jul 8, 2014

Critic review: https://critic.hoppipolla.co.uk/r/1990

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

Critic review: https://critic.hoppipolla.co.uk/r/1990

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@pcwalton

This comment has been minimized.

Show comment
Hide comment
@pcwalton

pcwalton Jul 9, 2014

Contributor

Did we decide not to make this a submodule? Anyway, r+

Contributor

pcwalton commented Jul 9, 2014

Did we decide not to make this a submodule? Anyway, r+

pcwalton added a commit that referenced this pull request Jul 9, 2014

Merge pull request #2786 from nnethercote/task_info
Add a `task_info` crate and a `task_basic_info` module within it.

@pcwalton pcwalton merged commit 94909f2 into servo:master Jul 9, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@nnethercote

This comment has been minimized.

Show comment
Hide comment
@nnethercote

nnethercote Jul 9, 2014

Contributor

Thanks for merging.

Did we decide not to make this a submodule?

In #2720 you suggested an instrumentation module, which I didn't end up doing because "I couldn't work out how to create a new module, and it also felt like overkill." It could certainly be done as a follow-up if necessary.

Contributor

nnethercote commented Jul 9, 2014

Thanks for merging.

Did we decide not to make this a submodule?

In #2720 you suggested an instrumentation module, which I didn't end up doing because "I couldn't work out how to create a new module, and it also felt like overkill." It could certainly be done as a follow-up if necessary.

@nnethercote nnethercote deleted the nnethercote:task_info branch Mar 24, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment