Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd basic support for web fonts. Synchronous loading only #2791
Conversation
hoppipolla-critic-bot
commented
Jul 9, 2014
|
Critic review: https://critic.hoppipolla.co.uk/r/2000 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
|
Whoa, sweet. |
|
This should eventually get a reftest. I recommend using the Ahem font, as it was explicitly designed for this: http://www.w3.org/Style/CSS/Test/Fonts/Ahem/ |
|
We need to start running the test for missing license headers on travis |
|
I’m reviewing the parsing code. |
|
Partial review done on Critic. |
|
Thanks for reviewing! I've pushed fixes for those and updated the critic review. |
|
**** NOTE: Even when this review is completed, it can't be merged until servo/core-graphics-rs#24 has landed and had submodule ptrs updated in servo **** ** The PR above has now landed in master, and travis is now passing - so this can be merged once the review is completed. ** |
|
r? @SimonSapin |
|
Rebased and updated to support new url parser. |
This comment has been minimized.
This comment has been minimized.
SimonSapin
commented on src/components/style/font_face.rs in a500099
Jul 25, 2014
|
Fix the FIXME by replacing the |
This comment has been minimized.
This comment has been minimized.
|
Fixed |
|
Would it be better if I split this into a few smaller PRs that are easier to review (e.g. CSS parsing separate from the platform specific font support etc)? |
|
I don’t think it would really help. We’d still need to be better than this at assigning reviewers :] |
|
Is this set to merge? All issues appear addressed. |
|
I kicked off a travis build this morning to make sure it is still green. |
This comment has been minimized.
This comment has been minimized.
larsbergstrom
commented on a37b5cb
Aug 5, 2014
|
r+ |
Add basic support for web fonts. Synchronous loading only
glennw commentedJul 9, 2014
for now, and only deals with TTF format fonts.
For an example, try loading http://icons.marekventur.de