Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upModify borders ref test to work on OS X #2874
Merged
Conversation
Issue #2848 has details. This commit uncomments the borders ref test in basic.list and modifies the test to work with viewports up to 4096px wide. Also as a workaround change the html element background to white, otherwise pixel (0,0) is black (it should be white since the border at pixel (0, 0) is white. The bug is mostly likely a regression in rust-layers.
hoppipolla-critic-bot
commented
Jul 19, 2014
|
Critic review: https://critic.hoppipolla.co.uk/r/2086 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
zwarich
commented
Jul 19, 2014
|
@bjwbell I'm giving this another run on Travis after the iframe changes to doublecheck that they agree, and then I'll merge. Can you open another issue for the pixel at (0, 0)? |
|
Fingers crossed, ill open the pixel issue when I'm back this evening |
zwarich
pushed a commit
that referenced
this pull request
Jul 19, 2014
Modify borders ref test to work on OS X
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
bjwbell commentedJul 19, 2014
Issue #2848 has details.
This commit uncomments the borders ref test in basic.list
and modifies the test to work with viewports up to 4096px wide.
As a workaround change the html element background to white,
otherwise pixel (0,0) is black (it should be white since the border
at pixel (0, 0) is white. The bug is likely a regression
in rust-layers.