Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rust-layers, removing a work-around in a test #2888

Closed
wants to merge 2 commits into from

Conversation

@mrobinson
Copy link
Member

mrobinson commented Jul 21, 2014

This fixes a regression caused by a previous rust-layers update. We can
now remove the work-around in the reftest.

Fixes #2879.

This fixes a regression caused by a previous rust-layers update. We can
now remove the work-around in the reftest.

Fixes #2879.
@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Jul 21, 2014

Critic review: https://critic.hoppipolla.co.uk/r/2107

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@zwarich
Copy link

zwarich commented Jul 21, 2014

Hmm, this breaks on OS X.

@zwarich
Copy link

zwarich commented Jul 21, 2014

But it works for me locally, both with and without HiDPI.

@larsbergstrom
Copy link
Contributor

larsbergstrom commented Jul 21, 2014

@zwarich The OSX builders are in a virtual machine on Travis - could that be related?

@zwarich
Copy link

zwarich commented Jul 21, 2014

@larsbergstrom I guess it would probably be using the OpenGL SW renderer rather than virtualizing the GPU, so I should try to force the SW renderer somehow and see if that causes a failure.

@zwarich
Copy link

zwarich commented Jul 22, 2014

@mrobinson I tried reproducing with every SW GL option I could find, but I had no luck. I find some other failures, which are probably just compositor races.

@mrobinson
Copy link
Member Author

mrobinson commented Jul 22, 2014

I have temporarily re-enabled the work-around just to ensure that travis now passes and that the test is not simply flaky.

@mrobinson
Copy link
Member Author

mrobinson commented Jul 22, 2014

Okay. OS X is passing so I suspect that there are multiple regressions here, but one is only appearing on the OS X travis-ci builder.

@mrobinson
Copy link
Member Author

mrobinson commented Jul 22, 2014

I'm going to abandon this PR for now until I can reproduce the issue that the bots are seeing. The checkout hash of rust-layers will progress regardless in some other PR, but we cannot unskip this test yet.

@mrobinson mrobinson closed this Jul 22, 2014
@mrobinson mrobinson deleted the mrobinson:zero-texture branch Jul 22, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can’t perform that action at this time.