Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2969 by only stripping HTML whitespace #2994

Merged
merged 2 commits into from Aug 5, 2014
Merged

Conversation

@ghost
Copy link

ghost commented Aug 4, 2014

No description provided.

@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Aug 4, 2014

Critic review: https://critic.hoppipolla.co.uk/r/2252

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@highfive
Copy link

highfive commented Aug 4, 2014

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @kmcallister (or someone else) soon.

@Ms2ger
Copy link
Contributor

Ms2ger commented Aug 4, 2014

@mechaxl: reviewed on critic

Ms2ger added a commit that referenced this pull request Aug 5, 2014
Only strip HTML whitespace in the document.title getter (fixes #2969); r=Ms2ger
@Ms2ger Ms2ger merged commit 40048b7 into servo:master Aug 5, 2014
1 check failed
1 check failed
continuous-integration/travis-ci The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.