Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement live HTMLCollection cache for Document.links #3037

Closed
wants to merge 6 commits into from

Conversation

@brunoabinader
Copy link
Contributor

brunoabinader commented Aug 6, 2014

Closes #1885.

@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Aug 6, 2014

Critic review: https://critic.hoppipolla.co.uk/r/2292

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@jdm
Copy link
Member

jdm commented Aug 8, 2014

ERROR:script::html::hubbub_html_parser: error loading script file:///Users/travis/build/servo/servo/src/test/content/src/test/content/harness.js

ERROR:js::rust: Error at file:///Users/travis/build/servo/servo/src/test/content/test_document_links_cache.html:8: ReferenceError: is_not is not defined
@brunoabinader brunoabinader deleted the brunoabinader:cache-document-links branch Aug 14, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.