Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSync submodule recursively #305
Merged
Conversation
Submodule may have its own submodules, and the sub-sub-module url may be changed. Thus, if `submodule update --recursive` is done without url sync, sub-sub-module may fail to find appropriate commit. This patch fixes the problem by `git submodule update` locally before recursive sync.
glennw
added a commit
to glennw/servo
that referenced
this pull request
Jan 16, 2017
Reduce the max texture size to 8192x8192 and 256MB.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
klutzy commentedMar 16, 2013
Submodule may have its own submodules, and the sub-sub-module url may be
changed.
Thus, if
submodule update --recursiveis done without url sync,sub-sub-module may fail to find appropriate commit.
This patch fixes the problem by
git submodule updatelocallybefore recursive sync.
I failed to run
./configurewhensrc/rustsubmodule has updated and thereforesrc/rust/src/libuvremote has changed (rust-lang/rust@c707a2d), but not synced byconfigure.