Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement DOMTokenList.contains #3061

Merged
merged 6 commits into from Aug 25, 2014
Merged

Implement DOMTokenList.contains #3061

merged 6 commits into from Aug 25, 2014

Conversation

@brunoabinader
Copy link
Contributor

brunoabinader commented Aug 8, 2014

Spec:
http://dom.spec.whatwg.org/#dom-domtokenlist-contains
@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Aug 8, 2014

Critic review: https://critic.hoppipolla.co.uk/r/2317

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.
@brunoabinader brunoabinader mentioned this pull request Aug 23, 2014
Merged
@brunoabinader
Copy link
Contributor Author

brunoabinader commented Aug 23, 2014

Travis CI build failed:

---- acid2_noscroll.html == acid2_ref_broken.html stdout ----

task 'acid2_noscroll.html == acid2_ref_broken.html' failed at 'rendering difference: /tmp/servo-reftest-000084-diff.png', /Users/travis/build/servo/servo/src/test/harness/reftest/reftest.rs:261

I've tested it locally and it gives the same output with a clean build from trunk. This also appeared in #3090, so given the evidences this failure seems out of the scope of this PR.
@brunoabinader brunoabinader mentioned this pull request Aug 23, 2014
Closed
@brunoabinader
Fixed AttrValue::from_tokenlist indexes
592454d 
The following issues were found:
 - Single concatenated spaces were indexed as a single token;
 - Last token, if not followed by an HTML space character, was ignored;
@brunoabinader
Implemented Attribute's tokens() iterator
e9f9afc
@brunoabinader
Use AttrValue::tokens() in Element::has_class()
d174501
@brunoabinader
Implement DOMTokenList.contains
caa55bf
@brunoabinader
Cleaned DOMTokenList code duplication
400a314
@brunoabinader
Mark WPT tests as FAIL due to lack of DOMTokenList.toggle
Loading status checks…
23d1d1c 
For now, these tests are being handled in test_element_classList.html
until DOMTokenList.toggle gets implemented.

Created issue #3138 to track DOMTokenList.toggle implementation.
Ms2ger added a commit that referenced this pull request Aug 25, 2014
@Ms2ger
Merge pull request #3061 from brunoabinader/domtokenlist
Loading status checks…
ce45280 
Implement DOMTokenList.contains; r=Ms2ger
@Ms2ger Ms2ger merged commit ce45280 into servo:master Aug 25, 2014
1 check passed
1 check passed
continuous-integration/travis-ci The Travis CI build passed
Details
@brunoabinader brunoabinader deleted the brunoabinader:domtokenlist branch Aug 25, 2014
@hmac
Copy link
Contributor

hmac commented Sep 4, 2014

This partially fixes #2973
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@brunoabinader @hoppipolla-critic-bot @hmac @Ms2ger
You can’t perform that action at this time.