Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upreplacing XXXjdm by throw_type_error in CodegenRust.py (see #347) #3065
Conversation
hoppipolla-critic-bot
commented
Aug 9, 2014
|
Critic review: https://critic.hoppipolla.co.uk/r/2320 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
highfive
commented
Aug 9, 2014
|
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @jdm (or someone else) soon. |
|
@schaars, thanks! I left some comments on critic; please leave your email address there. |
Ms2ger
added a commit
to Ms2ger/servo
that referenced
this pull request
Sep 4, 2014
…fixes servo#347, servo#3065)
Ms2ger
added a commit
to Ms2ger/servo
that referenced
this pull request
Sep 4, 2014
…fixes servo#347, servo#3065).
jdm
added a commit
that referenced
this pull request
Sep 4, 2014
|
Rebased and fixed up in #3207. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
plaublin commentedAug 9, 2014
Replacing the XXXjdm comments in CodegenRust.py by throw_type_error calls (see issue #347).